You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ke...@apache.org on 2016/11/22 20:11:25 UTC
[21/50] incubator-beam git commit: Remove dead code from
MetricsContainer
Remove dead code from MetricsContainer
Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/5fc68a5c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/5fc68a5c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/5fc68a5c
Branch: refs/heads/python-sdk
Commit: 5fc68a5c109fdbe3ed8afb370c8fcee803e9f1d8
Parents: 4852d2e
Author: bchambers <bc...@google.com>
Authored: Thu Nov 17 14:40:52 2016 -0800
Committer: bchambers <bc...@google.com>
Committed: Fri Nov 18 09:55:29 2016 -0800
----------------------------------------------------------------------
.../org/apache/beam/sdk/metrics/MetricsContainer.java | 13 -------------
1 file changed, 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/5fc68a5c/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsContainer.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsContainer.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsContainer.java
index 10032a2..ba5a343 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsContainer.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricsContainer.java
@@ -130,19 +130,6 @@ public class MetricsContainer {
* container.
*/
public MetricUpdates getCumulative() {
- ImmutableList.Builder<MetricUpdate<Long>> counterUpdates = ImmutableList.builder();
- for (Map.Entry<MetricName, CounterCell> counter : counters.entries()) {
- counterUpdates.add(MetricUpdate.create(
- MetricKey.create(stepName, counter.getKey()), counter.getValue().getCumulative()));
- }
-
- ImmutableList.Builder<MetricUpdate<DistributionData>> distributionUpdates =
- ImmutableList.builder();
- for (Map.Entry<MetricName, DistributionCell> distribution : distributions.entries()) {
- distributionUpdates.add(MetricUpdate.create(
- MetricKey.create(stepName, distribution.getKey()),
- distribution.getValue().getCumulative()));
- }
return MetricUpdates.create(
extractCumulatives(counters),
extractCumulatives(distributions));