You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:52:24 UTC

[GitHub] [incubator-nuttx] patacongo opened a new pull request #631: Revert "Makefile: move INCDIROPT to common place (#625)"

patacongo opened a new pull request #631: Revert "Makefile: move INCDIROPT to common place (#625)"
URL: https://github.com/apache/incubator-nuttx/pull/631
 
 
   This reverts commit b9ace36fcc7ccb55d1541231be07689d557628f4.
   
   This change was added by PR 625 but has a serious logic flaw.  It removes all occurrences of INCDIROPT and replaces it with a definition in tools/Config.mk:
   
       else ifeq ($(WINTOOL),y)
         DEFINE = "$(TOPDIR)/tools/define.sh"
         INCDIR = "$(TOPDIR)/tools/incdir.sh" -w
   
   This logic flaw is the Config.mk is included in all Make.defs files BEFORE WINTOOL is defined.  As a result, the definition is wrong in many places when building under Cygwin with a Windows native toolchain.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"

Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"
URL: https://github.com/apache/incubator-nuttx/pull/631#issuecomment-604476941
 
 
   All Cygwin users are dead in the water until this commit is reverted.  Refer to PR #625 for additional information

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"
URL: https://github.com/apache/incubator-nuttx/pull/631#issuecomment-604476941
 
 
   All Cygwin users are dead in the water until this commit is reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #631: Revert "Makefile: move INCDIROPT to common place (#625)"
URL: https://github.com/apache/incubator-nuttx/pull/631#issuecomment-604507159
 
 
   I have verified that if this change is reverted, the Cygwin build again works correctly.  Someone please merge.  We are not able to build anything now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] btashton merged pull request #631: Revert "Makefile: move INCDIROPT to common place (#625)"

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #631: Revert "Makefile: move INCDIROPT to common place (#625)"
URL: https://github.com/apache/incubator-nuttx/pull/631
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services