You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/16 15:21:42 UTC
[GitHub] [flink] sjwiesman opened a new pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
sjwiesman opened a new pull request #12915:
URL: https://github.com/apache/flink/pull/12915
## What is the purpose of the change
Update the training to use the modern `WatermarkStrategy` class in its examples.
I will backport this to 1.11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659492138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659483561
cc @alpinegizmo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] alpinegizmo commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
alpinegizmo commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659496434
Good catch! I'm happy with this. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659492442
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43f49b9259890aea61c9d5f44f68c104c352ee3f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "43f49b9259890aea61c9d5f44f68c104c352ee3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43f49b9259890aea61c9d5f44f68c104c352ee3f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659492442
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "43f49b9259890aea61c9d5f44f68c104c352ee3f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4562",
"triggerID" : "43f49b9259890aea61c9d5f44f68c104c352ee3f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 43f49b9259890aea61c9d5f44f68c104c352ee3f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4562)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659506563
Awesome, thank you both. Merging . . .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12915:
URL: https://github.com/apache/flink/pull/12915#issuecomment-659485164
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 43f49b9259890aea61c9d5f44f68c104c352ee3f (Thu Jul 16 15:24:14 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman closed pull request #12915: [FLINK-18619][docs] Update training to use WatermarkStrategy
Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #12915:
URL: https://github.com/apache/flink/pull/12915
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org