You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Benson Margulies <bi...@gmail.com> on 2008/02/25 18:39:29 UTC
Re: svn commit: r630931 - /incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
Should we stop using the service configuration in the bulk of the tests
instead?
On Mon, Feb 25, 2008 at 11:49 AM, <dk...@apache.org> wrote:
> Author: dkulp
> Date: Mon Feb 25 08:49:32 2008
> New Revision: 630931
>
> URL: http://svn.apache.org/viewvc?rev=630931&view=rev
> Log:
> Remove deprecation warning
>
> Modified:
>
> incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
>
> Modified:
> incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
> URL:
> http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java?rev=630931&r1=630930&r2=630931&view=diff
>
> ==============================================================================
> ---
> incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
> (original)
> +++
> incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
> Mon Feb 25 08:49:32 2008
> @@ -35,7 +35,6 @@
> import org.apache.cxf.BusException;
> import org.apache.cxf.BusFactory;
> import org.apache.cxf.aegis.databinding.AegisDatabinding;
> -import org.apache.cxf.aegis.databinding.AegisServiceConfiguration;
> import org.apache.cxf.binding.BindingFactoryManager;
> import org.apache.cxf.binding.soap.SoapBindingConstants;
> import org.apache.cxf.binding.soap.SoapBindingFactory;
> @@ -175,11 +174,13 @@
> protected void setupAegis(AbstractWSDLBasedEndpointFactory sf) {
> setupAegis(sf, null);
> }
> + @SuppressWarnings("deprecation")
> protected void setupAegis(AbstractWSDLBasedEndpointFactory sf,
> AegisDatabinding binding) {
> if (binding == null) {
> binding = new AegisDatabinding();
> }
> - sf.getServiceFactory().getServiceConfigurations().add(0, new
> AegisServiceConfiguration());
> + sf.getServiceFactory().getServiceConfigurations().add(0,
> + new
> org.apache.cxf.aegis.databinding.AegisServiceConfiguration());
> sf.getServiceFactory().setDataBinding(binding);
> }
>
>
>
>
Re: svn commit: r630931 - /incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java
Posted by Daniel Kulp <dk...@apache.org>.
On Monday 25 February 2008, Benson Margulies wrote:
> Should we stop using the service configuration in the bulk of the
> tests instead?
Well, I think it was only used in the one test. At least that's the only
one I saw the deprecation warning on. (maybe I need to do a clean)
In anycase, I would say the bulk of the tests should use the API's we
promote to use, but we do need at lease one test that does test the
deprecated stuff to make sure it still works until the deprecated stuff
is removed.
Dan
>
> On Mon, Feb 25, 2008 at 11:49 AM, <dk...@apache.org> wrote:
> > Author: dkulp
> > Date: Mon Feb 25 08:49:32 2008
> > New Revision: 630931
> >
> > URL: http://svn.apache.org/viewvc?rev=630931&view=rev
> > Log:
> > Remove deprecation warning
> >
> > Modified:
> >
> >
> > incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cx
> >f/aegis/AbstractAegisTest.java
> >
> > Modified:
> > incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cx
> >f/aegis/AbstractAegisTest.java URL:
> > http://svn.apache.org/viewvc/incubator/cxf/trunk/rt/databinding/aegi
> >s/src/test/java/org/apache/cxf/aegis/AbstractAegisTest.java?rev=63093
> >1&r1=630930&r2=630931&view=diff
> >
> > ====================================================================
> >========== ---
> > incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cx
> >f/aegis/AbstractAegisTest.java (original)
> > +++
> > incubator/cxf/trunk/rt/databinding/aegis/src/test/java/org/apache/cx
> >f/aegis/AbstractAegisTest.java Mon Feb 25 08:49:32 2008
> > @@ -35,7 +35,6 @@
> > import org.apache.cxf.BusException;
> > import org.apache.cxf.BusFactory;
> > import org.apache.cxf.aegis.databinding.AegisDatabinding;
> > -import org.apache.cxf.aegis.databinding.AegisServiceConfiguration;
> > import org.apache.cxf.binding.BindingFactoryManager;
> > import org.apache.cxf.binding.soap.SoapBindingConstants;
> > import org.apache.cxf.binding.soap.SoapBindingFactory;
> > @@ -175,11 +174,13 @@
> > protected void setupAegis(AbstractWSDLBasedEndpointFactory sf) {
> > setupAegis(sf, null);
> > }
> > + @SuppressWarnings("deprecation")
> > protected void setupAegis(AbstractWSDLBasedEndpointFactory sf,
> > AegisDatabinding binding) {
> > if (binding == null) {
> > binding = new AegisDatabinding();
> > }
> > - sf.getServiceFactory().getServiceConfigurations().add(0,
> > new AegisServiceConfiguration());
> > + sf.getServiceFactory().getServiceConfigurations().add(0,
> > + new
> > org.apache.cxf.aegis.databinding.AegisServiceConfiguration());
> > sf.getServiceFactory().setDataBinding(binding);
> > }
--
J. Daniel Kulp
Principal Engineer, IONA
dkulp@apache.org
http://www.dankulp.com/blog