[GitHub] [spark] viirya commented on a change in pull request #29776: [SPARK-32903][SQL] GeneratePredicate should be able to eliminate common sub-expressions

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #29776:
URL: https://github.com/apache/spark/pull/29776#discussion_r489791464



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodegenExpressionCachingSuite.scala
##########
@@ -109,3 +139,17 @@ case class MutableExpression() extends LeafExpression with CodegenFallback {
   override def nullable: Boolean = false
   override def dataType: DataType = BooleanType
 }
+
+/**
+ * An expression with evaluated state so we can know whether it is evaluated.
+ */
+case class MutableExpression2() extends LeafExpression with CodegenFallback {

Review comment:
       OK. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org