[GitHub] [lucene] sonatype-lift[bot] commented on a diff in pull request #828: LUCENE-10528: use Xvfb in test to avoid messing up user's desktop

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on code in PR #828:
URL: https://github.com/apache/lucene/pull/828#discussion_r855697073


##########
lucene/distribution/src/binary-release/bin/luke.sh:
##########
@@ -26,6 +26,11 @@ if [ -z "$LAUNCH_CMD" ]; then
 else
   # We are integration-testing. Force UTF-8 as the encoding.
   LAUNCH_OPTS=-Dfile.encoding=UTF-8
+  # check if Xvfb is available
+  if command -v xvfb-run > /dev/null 2>&1; then
+    LAUNCH_OPTS="$LAUNCH_CMD $LAUNCH_OPTS"
+    LAUNCH_CMD="xvfb-run"
+  fi
 fi
 
 "$LAUNCH_CMD" $LAUNCH_OPTS --module-path "$MODULES/modules:$MODULES/modules-thirdparty" --module org.apache.lucene.luke "$@"

Review Comment:
   *ShellCheck:*  Double quote to prevent globbing and word splitting.
   
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)
   
   ---
   
   Was this a good recommendation?
   [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=196214103&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=196214103&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=196214103&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=196214103&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=196214103&lift_comment_rating=5) ]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org