You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Konrad Windszus <ko...@gmx.de> on 2017/10/09 08:35:11 UTC
Canonical URL for Git
I understand that I can commit to both the Gitbox repo as well as the linked Github repo now. The former works without further actions for the latter 2fa needs to be enabled on github and the account needs to be properly linked.
I am wondering which of the two URLs should be used within the pom.xmls?
For me it would rather be the native gitbox URL (as documented now in https://reference.apache.org/committer/git) instead of the Github one. Mostly because gitbox is controlled by the ASF Infra team while Github is not.
Also for documentation purposes we should always point to mainly the Apache one and mention the Github repo as an additional option.
With https://github.com/apache/sling-site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl has been changed from git-wip to Github. IMHO this should rather be the gitbox url as this allows every committer to publish, even if she/he has not yet set-up the linking of the Github account. This makes publishing less error-prone as for the gitbox URL no further prerequisites need to be fulfilled and one can just commit with the Apache LDAP ID and password.
WDYT?
Konrad
Re: Canonical URL for Git
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Tuesday 10 October 2017 12:09:53 Bertrand Delacretaz wrote:
> Hi,
>
> On Tue, Oct 10, 2017 at 12:06 PM, Konrad Windszus <ko...@gmx.de> wrote:
> > ...I think as long as the ASF is fine with this I would also rather
> > promote the usage of Github instead of gitbox (because of its richer
> > feature set) and therefore I am finally convinced that entering the
> > Github SCM URL is fine there....
>
> I'm fine with that in general but cutting releases from ASF
> repositories is a strong requirement.
Therefore the canonical repos are at GitBox. I understand Robert's concerns
regarding stability, but CXF is doing it that way also (using GitHub's rich
features and GitBox as canonical repos) .
> Worst case we could add instructions to our release process, using git
> diff to compare the ASF and GitHub repositories before cutting a
> release.
We shouldn't make releasing more complicated.
Regards,
O.
> -Bertrand
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
I am only talking about the SCM URLs in Maven.
Not the general work.
Everyone can still use Github for the daily work. In fact I would even recommend that.
Only for releases we use Gitbox (but that is enforced by the maven-release-plugin together with the SCM info in the pom.xml) so no need for a developer to worry/care about that specifically.
That means you can do releases (in fact from Gitbox) even if your local clone is from Github.
> On 10. Oct 2017, at 12:36, Robert Munteanu <ro...@apache.org> wrote:
>
> On Tue, 2017-10-10 at 12:31 +0200, Bertrand Delacretaz wrote:
>> On Tue, Oct 10, 2017 at 12:26 PM, Robert Munteanu <rombert@apache.org
>>> wrote:
>>> ...Together with Konrad's notes on the Maven release plugin this
>>> makes a
>>> pretty strong case for using gitbox as the canonical URL
>>> everywhere...
>>
>> But we do other things much more often than releases, so it's hard to
>> give up the convenience...
>>
>> I don't have a better suggestion right now but I'm sure we can find a
>> convenient way to use GitHub for day-to-day work and gitbox for
>> releases. A Maven profile maybe?
>>
>> -Bertrand
>
> It should be fine to clone from and push to GitHub, but release from
> GitBox. After all, the commit hashes are the same and tags will be
> propagated to GitBox instantaneously.
>
> Or at least we'll know once we run the first release :-)
>
> Robert
Re: Canonical URL for Git
Posted by Robert Munteanu <ro...@apache.org>.
On Tue, 2017-10-10 at 12:31 +0200, Bertrand Delacretaz wrote:
> On Tue, Oct 10, 2017 at 12:26 PM, Robert Munteanu <rombert@apache.org
> > wrote:
> > ...Together with Konrad's notes on the Maven release plugin this
> > makes a
> > pretty strong case for using gitbox as the canonical URL
> > everywhere...
>
> But we do other things much more often than releases, so it's hard to
> give up the convenience...
>
> I don't have a better suggestion right now but I'm sure we can find a
> convenient way to use GitHub for day-to-day work and gitbox for
> releases. A Maven profile maybe?
>
> -Bertrand
It should be fine to clone from and push to GitHub, but release from
GitBox. After all, the commit hashes are the same and tags will be
propagated to GitBox instantaneously.
Or at least we'll know once we run the first release :-)
Robert
Re: Canonical URL for Git
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Oct 10, 2017 at 12:26 PM, Robert Munteanu <ro...@apache.org> wrote:
> ...Together with Konrad's notes on the Maven release plugin this makes a
> pretty strong case for using gitbox as the canonical URL everywhere...
But we do other things much more often than releases, so it's hard to
give up the convenience...
I don't have a better suggestion right now but I'm sure we can find a
convenient way to use GitHub for day-to-day work and gitbox for
releases. A Maven profile maybe?
-Bertrand
Re: Canonical URL for Git
Posted by Robert Munteanu <ro...@apache.org>.
On Tue, 2017-10-10 at 12:09 +0200, Bertrand Delacretaz wrote:
> Hi,
>
> On Tue, Oct 10, 2017 at 12:06 PM, Konrad Windszus <ko...@gmx.de>
> wrote:
> > ...I think as long as the ASF is fine with this I would also rather
> > promote the usage of Github instead
> > of gitbox (because of its richer feature set) and therefore I am
> > finally convinced that entering the Github
> > SCM URL is fine there....
>
> I'm fine with that in general but cutting releases from ASF
> repositories is a strong requirement.
>
> Worst case we could add instructions to our release process, using
> git
> diff to compare the ASF and GitHub repositories before cutting a
> release.
Hm, you're right and we should cut releases from the gitbox urls.
Together with Konrad's notes on the Maven release plugin this makes a
pretty strong case for using gitbox as the canonical URL everywhere.
Thanks,
Robert
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
Sorry I was wrong here, although the release:prepare steps don't do a fresh checkout the release:perform does it [2]. Therefore having the gitbox URL in the SCM information would fulfil that requirement
[2] - http://maven.apache.org/maven-release/maven-release-plugin/examples/perform-release.html
> On 10. Oct 2017, at 12:18, Konrad Windszus <ko...@gmx.de> wrote:
>
> To fulfill this requirement even having gitbox SCM URLs in our pom.xml would not suffice. Instead during the release one would need to do a fresh checkout from gitbox locally before building the release, because release:prepare does not do that[1].
> Instead prepare just takes the current working directory as source.
>
> [1] - http://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html
>
>
>> On 10. Oct 2017, at 12:09, Bertrand Delacretaz <bd...@apache.org> wrote:
>>
>> Hi,
>>
>> On Tue, Oct 10, 2017 at 12:06 PM, Konrad Windszus <ko...@gmx.de> wrote:
>>> ...I think as long as the ASF is fine with this I would also rather promote the usage of Github instead
>>> of gitbox (because of its richer feature set) and therefore I am finally convinced that entering the Github
>>> SCM URL is fine there....
>>
>> I'm fine with that in general but cutting releases from ASF
>> repositories is a strong requirement.
>>
>> Worst case we could add instructions to our release process, using git
>> diff to compare the ASF and GitHub repositories before cutting a
>> release.
>>
>> -Bertrand
>
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
To fulfill this requirement even having gitbox SCM URLs in our pom.xml would not suffice. Instead during the release one would need to do a fresh checkout from gitbox locally before building the release, because release:prepare does not do that[1].
Instead prepare just takes the current working directory as source.
[1] - http://maven.apache.org/maven-release/maven-release-plugin/examples/prepare-release.html
> On 10. Oct 2017, at 12:09, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> Hi,
>
> On Tue, Oct 10, 2017 at 12:06 PM, Konrad Windszus <ko...@gmx.de> wrote:
>> ...I think as long as the ASF is fine with this I would also rather promote the usage of Github instead
>> of gitbox (because of its richer feature set) and therefore I am finally convinced that entering the Github
>> SCM URL is fine there....
>
> I'm fine with that in general but cutting releases from ASF
> repositories is a strong requirement.
>
> Worst case we could add instructions to our release process, using git
> diff to compare the ASF and GitHub repositories before cutting a
> release.
>
> -Bertrand
Re: Canonical URL for Git
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Tue, Oct 10, 2017 at 12:06 PM, Konrad Windszus <ko...@gmx.de> wrote:
> ...I think as long as the ASF is fine with this I would also rather promote the usage of Github instead
> of gitbox (because of its richer feature set) and therefore I am finally convinced that entering the Github
> SCM URL is fine there....
I'm fine with that in general but cutting releases from ASF
repositories is a strong requirement.
Worst case we could add instructions to our release process, using git
diff to compare the ASF and GitHub repositories before cutting a
release.
-Bertrand
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
The problem really is what we want to enter in the pom.xmls. That information is used for the regular maven release process and this is where the commits are pushed to during the release. Only one repository url is supported there.
The information is not used for the actual CI builds, so for the Jenkins we can still decide which one to use independent of the scm information in the pom.xml.
But Robert's argument regarding what happens in case of parallel conflicting commits to both Github and gitbox is a very valid one.
I think as long as the ASF is fine with this I would also rather promote the usage of Github instead of gitbox (because of its richer feature set) and therefore I am finally convinced that entering the Github SCM URL is fine there.
Konrad
> On 10. Oct 2017, at 11:38, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> On Mon, Oct 9, 2017 at 7:58 PM, Chetan Mehrotra
> <ch...@gmail.com> wrote:
>> ...I believe Github would provide more convenience and if dual system is
>> approved then we should use Github as the preferred master...
>
> +1 but can we run tests and build releases from the ASF repositories?
> The goal being to make sure those are the "golden" ones.
>
> -Bertrand
Re: Canonical URL for Git
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Mon, Oct 9, 2017 at 7:58 PM, Chetan Mehrotra
<ch...@gmail.com> wrote:
> ...I believe Github would provide more convenience and if dual system is
> approved then we should use Github as the preferred master...
+1 but can we run tests and build releases from the ASF repositories?
The goal being to make sure those are the "golden" ones.
-Bertrand
Re: Canonical URL for Git
Posted by Chetan Mehrotra <ch...@gmail.com>.
I believe Github would provide more convenience and if dual system is
approved then we should use Github as the preferred master.
Chetan Mehrotra
On Mon, Oct 9, 2017 at 7:58 AM, Robert Munteanu <ro...@apache.org> wrote:
> On Mon, 2017-10-09 at 11:21 +0200, Konrad Windszus wrote:
>> > - account linking and personal access token generation are one-time
>> > actions that take little time to perform
>>
>> right, but at least for the sling-site case committing to gitbox is
>> even less effort, because every committer already has HTTPS write
>> access to that repo. I had some troubles with the linking because it
>> seems that after enabling 2fa on Github there is a delay of up to 30
>> minutes until the daemon picks up the change on ASF side.
>
> Yes, that is documented at https://gitbox.apache.org/setup/ .
>
>> > - making github the preferred push repository makes me more
>> > confident
>> > that we won't have any conflicts due to merging pull requests
>>
>> not sure how ASF gitbox and Github are syncing exactly and what
>> happens in case of conflicts. Do you have any source available which
>> explains the process more in detail? Also to me it is not clear which
>> URL to include there: SSH based or HTTPS based?
>
> Unfortunately no, that this is part of why I support one definite
> 'master' git repo to use.
>
> I would favour HTTPS as it's probably not filtered anywhere, whereas
> SSH is sometimes blocked by firewalls.
>
>> > - automation is more readily available with github rather than
>> > gitbox
>> > and we may choose to add more automation in the future
>>
>> you are probably referring to the Github API for which there is no
>> alternative on the ASF side. I agree with that as well. Also having
>> SSH authentication available at Github is a big pro (but should not
>> be required for publishing the sling site though)
>
> Yes, agreed, we should not require SSH for publishing.
>
>>
>> But please also consider the other points:
>> >
>> > Also, pushing to github is a supported setup, this was why we
>> > decided
>> > to go with gitbox in the first place [1]. Pushing to the ASF repos
>> > sort
>> > of defeats the purpose of that.
>>
>> Don't agree with that. Pushing to ASF repos does not prevent anyone
>> from using the Github repos.
>> It is just less obvious that you can also use Github.
>
> That circles back to how stable we think the dual-master setup is. Yes,
> we can try and use gitbox as a canonical repository and use Github as a
> remote only when needed.
>
>>
>> The main question to me is: how stable do we consider each of the two
>> repos?
>> IMHO the gitbox repo URL is much more stable as Github could
>> theoretically end at any point in time the collaboration with the ASF
>> and just would no longer provide that service for free. Modifying the
>> documentation and poms afterwards would be a big hassle.
>>
>> I guess providing Maven artifacts not only via Maven Central but
>> primarily through the ASF dist server is a very similar requirement (
>> http://www.apache.org/dev/release-publishing.html#distribution).
>> What do others think?
>
> My recollection is that the dual system is approved since a push to
> Github is automatically replicated to ASF servers - the source still
> lives on the ASF repos.
>
> -----
>
> Anyway, my understanding of what we aim to do might be wrong and since
> no one else seems to desire a canonical Github URL I'll switch the
> sling-site repo to publish via gitbox later today or early tomorrow.
>
> Robert
>
Re: Canonical URL for Git
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-10-09 at 11:21 +0200, Konrad Windszus wrote:
> > - account linking and personal access token generation are one-time
> > actions that take little time to perform
>
> right, but at least for the sling-site case committing to gitbox is
> even less effort, because every committer already has HTTPS write
> access to that repo. I had some troubles with the linking because it
> seems that after enabling 2fa on Github there is a delay of up to 30
> minutes until the daemon picks up the change on ASF side.
Yes, that is documented at https://gitbox.apache.org/setup/ .
> > - making github the preferred push repository makes me more
> > confident
> > that we won't have any conflicts due to merging pull requests
>
> not sure how ASF gitbox and Github are syncing exactly and what
> happens in case of conflicts. Do you have any source available which
> explains the process more in detail? Also to me it is not clear which
> URL to include there: SSH based or HTTPS based?
Unfortunately no, that this is part of why I support one definite
'master' git repo to use.
I would favour HTTPS as it's probably not filtered anywhere, whereas
SSH is sometimes blocked by firewalls.
> > - automation is more readily available with github rather than
> > gitbox
> > and we may choose to add more automation in the future
>
> you are probably referring to the Github API for which there is no
> alternative on the ASF side. I agree with that as well. Also having
> SSH authentication available at Github is a big pro (but should not
> be required for publishing the sling site though)
Yes, agreed, we should not require SSH for publishing.
>
> But please also consider the other points:
> >
> > Also, pushing to github is a supported setup, this was why we
> > decided
> > to go with gitbox in the first place [1]. Pushing to the ASF repos
> > sort
> > of defeats the purpose of that.
>
> Don't agree with that. Pushing to ASF repos does not prevent anyone
> from using the Github repos.
> It is just less obvious that you can also use Github.
That circles back to how stable we think the dual-master setup is. Yes,
we can try and use gitbox as a canonical repository and use Github as a
remote only when needed.
>
> The main question to me is: how stable do we consider each of the two
> repos?
> IMHO the gitbox repo URL is much more stable as Github could
> theoretically end at any point in time the collaboration with the ASF
> and just would no longer provide that service for free. Modifying the
> documentation and poms afterwards would be a big hassle.
>
> I guess providing Maven artifacts not only via Maven Central but
> primarily through the ASF dist server is a very similar requirement (
> http://www.apache.org/dev/release-publishing.html#distribution).
> What do others think?
My recollection is that the dual system is approved since a push to
Github is automatically replicated to ASF servers - the source still
lives on the ASF repos.
-----
Anyway, my understanding of what we aim to do might be wrong and since
no one else seems to desire a canonical Github URL I'll switch the
sling-site repo to publish via gitbox later today or early tomorrow.
Robert
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
Hi Robert,
see my comment inline
> On 9. Oct 2017, at 10:54, Robert Munteanu <ro...@apache.org> wrote:
>
> Hi,
>
> On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote:
>> I understand that I can commit to both the Gitbox repo as well as the
>> linked Github repo now. The former works without further actions for
>> the latter 2fa needs to be enabled on github and the account needs to
>> be properly linked.
>> I am wondering which of the two URLs should be used within the
>> pom.xmls?
>> For me it would rather be the native gitbox URL (as documented now in
>> https://reference.apache.org/committer/git) instead of the Github
>> one. Mostly because gitbox is controlled by the ASF Infra team while
>> Github is not.
>> Also for documentation purposes we should always point to mainly the
>> Apache one and mention the Github repo as an additional option.
>>
>> With https://github.com/apache/sling-
>> site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl
>> has been changed from git-wip to Github. IMHO this should rather be
>> the gitbox url as this allows every committer to publish, even if
>> she/he has not yet set-up the linking of the Github account. This
>> makes publishing less error-prone as for the gitbox URL no further
>> prerequisites need to be fulfilled and one can just commit with the
>> Apache LDAP ID and password.
>
> Thanks for bringing this up, I don't think we explicitly discussed it.
>
> I think that github should be the canonical URL, for the following
> reasons:
>
> - account linking and personal access token generation are one-time
> actions that take little time to perform
right, but at least for the sling-site case committing to gitbox is even less effort, because every committer already has HTTPS write access to that repo. I had some troubles with the linking because it seems that after enabling 2fa on Github there is a delay of up to 30 minutes until the daemon picks up the change on ASF side.
> - making github the preferred push repository makes me more confident
> that we won't have any conflicts due to merging pull requests
not sure how ASF gitbox and Github are syncing exactly and what happens in case of conflicts. Do you have any source available which explains the process more in detail? Also to me it is not clear which URL to include there: SSH based or HTTPS based?
> - automation is more readily available with github rather than gitbox
> and we may choose to add more automation in the future
you are probably referring to the Github API for which there is no alternative on the ASF side. I agree with that as well. Also having SSH authentication available at Github is a big pro (but should not be required for publishing the sling site though)
But please also consider the other points:
>
> Also, pushing to github is a supported setup, this was why we decided
> to go with gitbox in the first place [1]. Pushing to the ASF repos sort
> of defeats the purpose of that.
Don't agree with that. Pushing to ASF repos does not prevent anyone from using the Github repos.
It is just less obvious that you can also use Github.
The main question to me is: how stable do we consider each of the two repos?
IMHO the gitbox repo URL is much more stable as Github could theoretically end at any point in time the collaboration with the ASF and just would no longer provide that service for free. Modifying the documentation and poms afterwards would be a big hassle.
I guess providing Maven artifacts not only via Maven Central but primarily through the ASF dist server is a very similar requirement (http://www.apache.org/dev/release-publishing.html#distribution).
What do others think?
>
> Robert
>
> [1]: https://lists.apache.org/thread.html/5ec516396d30c5c6b722da8095230
> a792f0972ab25dd651a96dd56be@%3Cdev.sling.apache.org%3E
Re: Canonical URL for Git
Posted by Robert Munteanu <ro...@apache.org>.
On Mon, 2017-10-09 at 11:22 +0200, Oliver Lietz wrote:
> > Also, pushing to github is a supported setup, this was why we
> > decided
> > to go with gitbox in the first place [1]. Pushing to the ASF repos
> > sort
> > of defeats the purpose of that.
>
> why is making GitBox URLs the canonical ones (IMHO those URLs *are*
> the
> canonical ones) defeating anything?
I am wary of pushing to different repositories since I am not 100%
certain of the stability of the dual master setup. If we push to just
one repo - github or gitbox - then we will not have any issues with
repositories getting out of sync.
Following that reasoning, we should only push to gitbox if we make that
the canonical URL, therefore we should discourage using Github as a
remote, including merging pull requests and any automation around
Github as a remote.
If we do that, then it makes no sense to move to gitbox and instead
move to read-only mirrors on Github and use git-wip as a system.
Thanks,
Robert
Re: Canonical URL for Git
Posted by Konrad Windszus <ko...@gmx.de>.
When looking at other projects, this is how Apache CXF
1. documents it: http://cxf.apache.org/source-repository.html
2. and uses it in Maven: https://github.com/apache/cxf/blob/master/pom.xml#L31
So gitbox is the canonical one there.
> On 9. Oct 2017, at 11:22, Oliver Lietz <ap...@oliverlietz.de> wrote:
>
> On Monday 09 October 2017 11:54:17 Robert Munteanu wrote:
>> Hi,
>
> Hi,
>
>> On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote:
>>> I understand that I can commit to both the Gitbox repo as well as the
>>> linked Github repo now. The former works without further actions for
>>> the latter 2fa needs to be enabled on github and the account needs to
>>> be properly linked.
>>> I am wondering which of the two URLs should be used within the
>>> pom.xmls?
>>> For me it would rather be the native gitbox URL (as documented now in
>>> https://reference.apache.org/committer/git) instead of the Github
>>> one. Mostly because gitbox is controlled by the ASF Infra team while
>>> Github is not.
>>> Also for documentation purposes we should always point to mainly the
>>> Apache one and mention the Github repo as an additional option.
>>>
>>> With https://github.com/apache/sling-> > site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl
>>> has been changed from git-wip to Github. IMHO this should rather be
>>> the gitbox url as this allows every committer to publish, even if
>>> she/he has not yet set-up the linking of the Github account. This
>>> makes publishing less error-prone as for the gitbox URL no further
>>> prerequisites need to be fulfilled and one can just commit with the
>>> Apache LDAP ID and password.
>>
>> Thanks for bringing this up, I don't think we explicitly discussed it.
>>
>> I think that github should be the canonical URL, for the following
>> reasons:
>>
>> - account linking and personal access token generation are one-time
>> actions that take little time to perform
>> - making github the preferred push repository makes me more confident
>> that we won't have any conflicts due to merging pull requests
>> - automation is more readily available with github rather than gitbox
>> and we may choose to add more automation in the future
>>
>> Also, pushing to github is a supported setup, this was why we decided
>> to go with gitbox in the first place [1]. Pushing to the ASF repos sort
>> of defeats the purpose of that.
>
> why is making GitBox URLs the canonical ones (IMHO those URLs *are* the
> canonical ones) defeating anything?
>
> Regards,
> O.
>
>> Robert
>>
>> [1]: https://lists.apache.org/thread.html/5ec516396d30c5c6b722da8095230
>> a792f0972ab25dd651a96dd56be@%3Cdev.sling.apache.org%3E
Re: Canonical URL for Git
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Monday 09 October 2017 11:54:17 Robert Munteanu wrote:
> Hi,
Hi,
> On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote:
> > I understand that I can commit to both the Gitbox repo as well as the
> > linked Github repo now. The former works without further actions for
> > the latter 2fa needs to be enabled on github and the account needs to
> > be properly linked.
> > I am wondering which of the two URLs should be used within the
> > pom.xmls?
> > For me it would rather be the native gitbox URL (as documented now in
> > https://reference.apache.org/committer/git) instead of the Github
> > one. Mostly because gitbox is controlled by the ASF Infra team while
> > Github is not.
> > Also for documentation purposes we should always point to mainly the
> > Apache one and mention the Github repo as an additional option.
> >
> > With https://github.com/apache/sling-> > site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl
> > has been changed from git-wip to Github. IMHO this should rather be
> > the gitbox url as this allows every committer to publish, even if
> > she/he has not yet set-up the linking of the Github account. This
> > makes publishing less error-prone as for the gitbox URL no further
> > prerequisites need to be fulfilled and one can just commit with the
> > Apache LDAP ID and password.
>
> Thanks for bringing this up, I don't think we explicitly discussed it.
>
> I think that github should be the canonical URL, for the following
> reasons:
>
> - account linking and personal access token generation are one-time
> actions that take little time to perform
> - making github the preferred push repository makes me more confident
> that we won't have any conflicts due to merging pull requests
> - automation is more readily available with github rather than gitbox
> and we may choose to add more automation in the future
>
> Also, pushing to github is a supported setup, this was why we decided
> to go with gitbox in the first place [1]. Pushing to the ASF repos sort
> of defeats the purpose of that.
why is making GitBox URLs the canonical ones (IMHO those URLs *are* the
canonical ones) defeating anything?
Regards,
O.
> Robert
>
> [1]: https://lists.apache.org/thread.html/5ec516396d30c5c6b722da8095230
> a792f0972ab25dd651a96dd56be@%3Cdev.sling.apache.org%3E
Re: Canonical URL for Git
Posted by Robert Munteanu <ro...@apache.org>.
Hi,
On Mon, 2017-10-09 at 10:35 +0200, Konrad Windszus wrote:
> I understand that I can commit to both the Gitbox repo as well as the
> linked Github repo now. The former works without further actions for
> the latter 2fa needs to be enabled on github and the account needs to
> be properly linked.
> I am wondering which of the two URLs should be used within the
> pom.xmls?
> For me it would rather be the native gitbox URL (as documented now in
> https://reference.apache.org/committer/git) instead of the Github
> one. Mostly because gitbox is controlled by the ASF Infra team while
> Github is not.
> Also for documentation purposes we should always point to mainly the
> Apache one and mention the Github repo as an additional option.
>
> With https://github.com/apache/sling-
> site/commit/2f5dbedefff3fcaa0639716d59c0806620337fd0 the pubScmUrl
> has been changed from git-wip to Github. IMHO this should rather be
> the gitbox url as this allows every committer to publish, even if
> she/he has not yet set-up the linking of the Github account. This
> makes publishing less error-prone as for the gitbox URL no further
> prerequisites need to be fulfilled and one can just commit with the
> Apache LDAP ID and password.
Thanks for bringing this up, I don't think we explicitly discussed it.
I think that github should be the canonical URL, for the following
reasons:
- account linking and personal access token generation are one-time
actions that take little time to perform
- making github the preferred push repository makes me more confident
that we won't have any conflicts due to merging pull requests
- automation is more readily available with github rather than gitbox
and we may choose to add more automation in the future
Also, pushing to github is a supported setup, this was why we decided
to go with gitbox in the first place [1]. Pushing to the ASF repos sort
of defeats the purpose of that.
Robert
[1]: https://lists.apache.org/thread.html/5ec516396d30c5c6b722da8095230
a792f0972ab25dd651a96dd56be@%3Cdev.sling.apache.org%3E