You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2020/05/14 07:35:56 UTC

[pulsar-helm-chart] branch master updated: symmetric / create_namespace flags were only working if last argument (#11)

This is an automated email from the ASF dual-hosted git repository.

sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar-helm-chart.git


The following commit(s) were added to refs/heads/master by this push:
     new 45fd2c6  symmetric / create_namespace flags were only working if last argument (#11)
45fd2c6 is described below

commit 45fd2c6878ec171a7b7d894d75fa13b55e404cf4
Author: Luke Stephenson <lu...@gmail.com>
AuthorDate: Thu May 14 17:35:48 2020 +1000

    symmetric / create_namespace flags were only working if last argument (#11)
    
    Move defaults outside the while loop so they are not constantly reset
    
    Fixes #10
---
 scripts/pulsar/prepare_helm_release.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/pulsar/prepare_helm_release.sh b/scripts/pulsar/prepare_helm_release.sh
index d231916..482bd49 100755
--- a/scripts/pulsar/prepare_helm_release.sh
+++ b/scripts/pulsar/prepare_helm_release.sh
@@ -36,14 +36,13 @@ Usage:
 EOF
 }
 
+symmetric=false
+create_namespace=false
 
 while [[ $# -gt 0 ]]
 do
 key="$1"
 
-symmetric=false
-create_namespace=false
-
 case $key in
     -n|--namespace)
     namespace="$2"