You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/09/12 15:46:39 UTC
[GitHub] codecov-io edited a comment on issue #440: SCB-902 Support service
discovery by Service Mesh
codecov-io edited a comment on issue #440: SCB-902 Support service discovery by Service Mesh
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/440#issuecomment-420530900
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=h1) Report
> Merging [#440](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/e24e73eddb66aed71653c5f7845e5d3053f783a9?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `63.63%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
- Coverage 59.79% 59.76% -0.04%
==========================================
Files 149 149
Lines 13165 13169 +4
==========================================
- Hits 7872 7870 -2
- Misses 4721 4726 +5
- Partials 572 573 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/util/rule\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9ydWxlX3V0aWwuZ28=) | `64.28% <0%> (-0.78%)` | :arrow_down: |
| [server/service/instance\_validator.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VfdmFsaWRhdG9yLmdv) | `100% <100%> (ø)` | :arrow_up: |
| [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.21% <66.66%> (-0.85%)` | :arrow_down: |
| [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `70.16% <0%> (-0.41%)` | :arrow_down: |
| [server/plugin/infra/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9pbmZyYS9yZWdpc3RyeS9ldGNkL2V0Y2QuZ28=) | `86.76% <0%> (ø)` | :arrow_up: |
| [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=footer). Last update [e24e73e...8f1f3db](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/440?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services