You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-dev@portals.apache.org by "Christophe Jolif (JIRA)" <br...@portals.apache.org> on 2007/01/10 15:45:27 UTC
[jira] Created: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
-----------------------------------------------------------------------------------------------------------------------
Key: PB-55
URL: https://issues.apache.org/jira/browse/PB-55
Project: Portals Bridges
Issue Type: Bug
Components: jsf
Affects Versions: 1.0
Reporter: Christophe Jolif
Priority: Critical
FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
Indeed JSF spec says the signature of the method is the following:
getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463610 ]
Christophe Jolif commented on PB-55:
------------------------------------
Oups, indeed I attached a buggy fix :-(
This one:
https://issues.apache.org/jira/secure/attachment/12348658/FacesContextFactoryImpl.java
should be fine.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif updated PB-55:
-------------------------------
Attachment: FacesContextFactoryImpl.java
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Matthew Bruzek (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463721 ]
Matthew Bruzek commented on PB-55:
----------------------------------
I made the suggested change to FacesContextFactoryImpl.java and an additional change to FacesPortlet.java in my sandbox. With those two small changes I was able to get my application past the problem I was seeing. It worked!
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif updated PB-55:
-------------------------------
Attachment: FacesContextFactoryImpl.java
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Matthew Bruzek (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463605 ]
Matthew Bruzek commented on PB-55:
----------------------------------
This bug is preventing my application from working.
The suggested fixed version also contains a error They removed the parameter "config", but there are still references to that variable in the method. The the following if statement if (config instanceof PortletConfig) and the string "Unsupported context type " + config.getClass().getName() would need to be changed. After those changes are made the file should compile cleanly.
Also it looks like org.apache.portals.bridges.jsf.FacesPortlet is the only class to call this getFacesContext(), in the private process() method.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Assigned: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor reassigned PB-55:
-----------------------------------
Assignee: David Sean Taylor
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Resolved: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor resolved PB-55.
---------------------------------
Resolution: Fixed
patch applied
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Reopened: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif reopened PB-55:
--------------------------------
I'm sorry to reopen this issue but it seems to me that even though the fixed file as been correctly applied, the call to the fixed method have not been changed.
Here is a patch:
https://issues.apache.org/jira/secure/attachment/12348996/FacesPortlet.java
that should also fix the call.
Thank you very much!
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesPortlet.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif updated PB-55:
-------------------------------
Attachment: FacesContextFactoryImpl.java
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Work started: (PB-55)
FacesContextFactoryImpl.getFacesContext takes a config as first parameter
instead of a context as specified in JSF spec
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on PB-55 started by David Sean Taylor.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Updated: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christophe Jolif updated PB-55:
-------------------------------
Attachment: FacesPortlet.java
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesPortlet.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Commented: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "Christophe Jolif (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463566 ]
Christophe Jolif commented on PB-55:
------------------------------------
https://issues.apache.org/jira/secure/attachment/12348654/FacesContextFactoryImpl.java is a fixed version of the file. Of course call to Factory must also be fixed to pass the context instead of the config.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org
[jira] Resolved: (PB-55) FacesContextFactoryImpl.getFacesContext
takes a config as first parameter instead of a context as specified in JSF
spec
Posted by "David Sean Taylor (JIRA)" <br...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor resolved PB-55.
---------------------------------
Resolution: Fixed
Fix Version/s: POST-1.0
patch applied.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Assigned To: David Sean Taylor
> Priority: Critical
> Fix For: POST-1.0
>
> Attachments: FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesContextFactoryImpl.java, FacesPortlet.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request, java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object (and that's actually what the reference implementation JSF bridge is expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-dev-help@portals.apache.org