You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/08 04:07:21 UTC

[GitHub] [kafka] chia7712 commented on pull request #10017: KAFKA-12260: Avoid hitting NPE for partitionsFor

chia7712 commented on pull request #10017:
URL: https://github.com/apache/kafka/pull/10017#issuecomment-774852045


   @abbccdda Thanks for updating code. Two minor comments are left.
   
   1. The docs of ```KafkaConsumer#partitionsFor(String topic, Duration timeout)``` is not updated. 
   1. ```MockConsumer``` still return null when `topic` is nonexistent. Should we make it return empty collection as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org