You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "vsantwana (via GitHub)" <gi...@apache.org> on 2025/12/29 11:07:53 UTC
[PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
vsantwana opened a new pull request, #27370:
URL: https://github.com/apache/flink/pull/27370
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-4109802988
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal merged PR #27370:
URL: https://github.com/apache/flink/pull/27370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "rmetzger (via GitHub)" <gi...@apache.org>.
rmetzger commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2668838582
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,22 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal JSON message is '%s'",
Review Comment:
nit to the nit: It is not the same content. `%s` vs `{}`. Sharing this string would potentially make the whole code unnecessarily complex, and this part of the code is probably performance critical.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-4111869404
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-4044719177
Hi, @vsantwana May I know the latest progress about the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652702077
##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonSerDeSchemaTest.java:
##########
@@ -105,6 +112,34 @@ void testIgnoreParseErrors() throws Exception {
"An error occurred while collecting data."));
}
+ @Test
+ void testIgnoreParseErrorsLogsDebugMessage() throws Exception {
Review Comment:
could you add a test case for fail on missing as well please. This also comes though out of the converts as a JsonParseException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-4114787913
<img width="2282" height="534" lt="image" src="https://github.com/user-attachments/assets/d0a0e68e-4153-4c9c-a7bb-d87b263c41b9" />
CC @vsantwana
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652510577
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/AbstractJsonDeserializationSchema.java:
##########
@@ -155,4 +161,16 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(failOnMissingField, ignoreParseErrors, resultTypeInfo, timestampFormat);
}
+
+ /**
+ * Logs a debug message for parsing errors only when debug logs are enabled.
+ *
+ * @param message the original JSON message that failed to parse
+ * @param t the throwable that was caught
+ */
+ protected void logParseErrorIfDebugEnabled(byte[] message, Throwable t) {
Review Comment:
Oh no! (* feels stupid *)
Somehow the changes did not get pushed. Pushed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652686431
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,22 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal JSON message is '%s'",
Review Comment:
nit: the IOException is the same as the debug content - can we use the same variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652329696
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/AbstractJsonDeserializationSchema.java:
##########
@@ -155,4 +161,16 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(failOnMissingField, ignoreParseErrors, resultTypeInfo, timestampFormat);
}
+
+ /**
+ * Logs a debug message for parsing errors only when debug logs are enabled.
+ *
+ * @param message the original JSON message that failed to parse
+ * @param t the throwable that was caught
+ */
+ protected void logParseErrorIfDebugEnabled(byte[] message, Throwable t) {
Review Comment:
-> logIgnoredParseErrorIfDebugEnabled
BTW, The previous calling is not changed. Pls have a look ~ thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-3698657524
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652702077
##########
flink-formats/flink-json/src/test/java/org/apache/flink/formats/json/canal/CanalJsonSerDeSchemaTest.java:
##########
@@ -105,6 +112,34 @@ void testIgnoreParseErrors() throws Exception {
"An error occurred while collecting data."));
}
+ @Test
+ void testIgnoreParseErrorsLogsDebugMessage() throws Exception {
Review Comment:
could you add a test case for fail on missing as well please. This also comes out of `JsonParserToRowDataConverters` as a `JsonParseException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2652329696
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/AbstractJsonDeserializationSchema.java:
##########
@@ -155,4 +161,16 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(failOnMissingField, ignoreParseErrors, resultTypeInfo, timestampFormat);
}
+
+ /**
+ * Logs a debug message for parsing errors only when debug logs are enabled.
+ *
+ * @param message the original JSON message that failed to parse
+ * @param t the throwable that was caught
+ */
+ protected void logParseErrorIfDebugEnabled(byte[] message, Throwable t) {
Review Comment:
BTW, The previous calling is not changed. Pls have a look ~ thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-3696234734
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6490362e1047d0a1e1d65f91b64afece1c540cf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6490362e1047d0a1e1d65f91b64afece1c540cf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6490362e1047d0a1e1d65f91b64afece1c540cf6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2668931265
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,22 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal JSON message is '%s'",
Review Comment:
fair point - lets not do this nit. .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-4115487680
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #27370:
URL: https://github.com/apache/flink/pull/27370#discussion_r2651262835
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/AbstractJsonDeserializationSchema.java:
##########
@@ -155,4 +161,14 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(failOnMissingField, ignoreParseErrors, resultTypeInfo, timestampFormat);
}
+
+ /**
+ * Logs a debug message when a JSON parse error is ignored.
+ *
+ * @param message the original JSON message that failed to parse
+ * @param t the throwable that was caught
+ */
+ protected void logParseError(byte[] message, Throwable t) {
+ LOG.debug("Failed to deserialize JSON '{}'.", new String(message), t);
Review Comment:
```suggestion
if (LOG.isDebugEnabled()) {
LOG.debug("Failed to deserialize JSON '{}'.", new String(message), t);
}
```
What about using pre-judge for logger level ?
Because we could reduce one redundant bytes array allocation if the logger level is not enabled debug or lower levels
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/debezium/DebeziumJsonDeserializationSchema.java:
##########
@@ -176,13 +182,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"op\" value \"%s\". The Debezium JSON message is '%s'",
op, new String(message)));
}
+ LOG.debug(
+ "Unknown \"op\" value '{}'. The Debezium JSON message is '{}'.",
+ op,
+ new String(message));
}
} catch (Throwable t) {
// a big try catch to protect the processing.
if (!ignoreParseErrors) {
throw new IOException(
format("Corrupt Debezium JSON message '%s'.", new String(message)), t);
}
+ LOG.debug("Corrupt Debezium JSON message '{}'.", new String(message), t);
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/ogg/OggJsonDeserializationSchema.java:
##########
@@ -198,13 +203,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"op_type\" value \"%s\". The Ogg JSON message is '%s'",
op, new String(message)));
}
+ LOG.debug(
+ "Unknown \"op_type\" value '{}'. The Ogg JSON message is '{}'.",
+ op,
+ new String(message));
}
} catch (Throwable t) {
// a big try catch to protect the processing.
if (!ignoreParseErrors) {
throw new IOException(
format("Corrupt Ogg JSON message '%s'.", new String(message)), t);
}
+ LOG.debug("Corrupt Ogg JSON message '{}'.", new String(message), t);
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/AbstractJsonDeserializationSchema.java:
##########
@@ -155,4 +161,14 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(failOnMissingField, ignoreParseErrors, resultTypeInfo, timestampFormat);
}
+
+ /**
+ * Logs a debug message when a JSON parse error is ignored.
+ *
+ * @param message the original JSON message that failed to parse
+ * @param t the throwable that was caught
+ */
+ protected void logParseError(byte[] message, Throwable t) {
Review Comment:
what about naming to `logIgnoredParseErrorIfDebugEnabled` ?
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonDeserializationSchema.java:
##########
@@ -171,13 +177,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"type\" value \"%s\". The Maxwell JSON message is '%s'",
type, new String(message)));
}
+ LOG.debug(
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,18 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal JSON message is '%s'",
type, new String(message)));
}
+ LOG.debug(
+ "Unknown \"type\" value '{}'. The Canal JSON message is '{}'.",
+ type,
+ new String(message));
}
} catch (Throwable t) {
// a big try catch to protect the processing.
if (!ignoreParseErrors) {
throw new IOException(
format("Corrupt Canal JSON message '%s'.", new String(message)), t);
}
+ LOG.debug("Corrupt Canal JSON message '{}'.", new String(message), t);
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/debezium/DebeziumJsonDeserializationSchema.java:
##########
@@ -176,13 +182,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"op\" value \"%s\". The Debezium JSON message is '%s'",
op, new String(message)));
}
+ LOG.debug(
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/ogg/OggJsonDeserializationSchema.java:
##########
@@ -198,13 +203,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"op_type\" value \"%s\". The Ogg JSON message is '%s'",
op, new String(message)));
}
+ LOG.debug(
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/maxwell/MaxwellJsonDeserializationSchema.java:
##########
@@ -171,13 +177,18 @@ public void deserialize(byte[] message, Collector<RowData> out) throws IOExcepti
"Unknown \"type\" value \"%s\". The Maxwell JSON message is '%s'",
type, new String(message)));
}
+ LOG.debug(
+ "Unknown \"type\" value '{}'. The Maxwell JSON message is '{}'.",
+ type,
+ new String(message));
}
} catch (Throwable t) {
// a big try catch to protect the processing.
if (!ignoreParseErrors) {
throw new IOException(
format("Corrupt Maxwell JSON message '%s'.", new String(message)), t);
}
+ LOG.debug("Corrupt Maxwell JSON message '{}'.", new String(message), t);
Review Comment:
ditto
##########
flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java:
##########
@@ -288,13 +293,18 @@ public void deserialize(@Nullable byte[] message, Collector<RowData> out) throws
"Unknown \"type\" value \"%s\". The Canal JSON message is '%s'",
type, new String(message)));
}
+ LOG.debug(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "vsantwana (via GitHub)" <gi...@apache.org>.
vsantwana commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-3698409663
Thanks @RocMarshal for the review. I have addressed the comments. PTAL!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38819] Add debug logs for serialisation errors [flink]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #27370:
URL: https://github.com/apache/flink/pull/27370#issuecomment-3709566438
Thanks @vsantwana for the ping.
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=71507&view=logs&j=2e8cb2f7-b2d3-5c62-9c05-cd756d33a819&t=2dd510a3-5041-5201-6dc3-54d310f68906
Could you help check the CI-failure ? thx :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org