You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by vs...@apache.org on 2008/02/17 16:01:24 UTC
svn commit: r628490 -
/maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
Author: vsiveton
Date: Sun Feb 17 07:01:23 2008
New Revision: 628490
URL: http://svn.apache.org/viewvc?rev=628490&view=rev
Log:
o improved code readingness and javadoc
Modified:
maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
Modified: maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java
URL: http://svn.apache.org/viewvc/maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java?rev=628490&r1=628489&r2=628490&view=diff
==============================================================================
--- maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java (original)
+++ maven/plugin-tools/trunk/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/AbstractMojoTestCase.java Sun Feb 17 07:01:23 2008
@@ -42,7 +42,7 @@
/**
* TODO: add a way to use the plugin POM for the lookup so that the user doesn't have to provide the a:g:v:goal
* as the role hint for the mojo lookup.
- * TODO: standarize the execution of the mojo and looking at the results, but could simply have a template method
+ * TODO: standardize the execution of the mojo and looking at the results, but could simply have a template method
* for verifying the state of the mojo post execution
* TODO: need a way to look at the state of the mojo without adding getters, this could be where we finally specify
* the expressions which extract values from the mojo.
@@ -303,7 +303,7 @@
}
/**
- * convience method to obtain the value of a variable on a mojo that might not have a getter.
+ * Convenience method to obtain the value of a variable on a mojo that might not have a getter.
*
* NOTE: the caller is responsible for casting to to what the desired type is.
*
@@ -323,7 +323,7 @@
}
/**
- * convience method to obtain all variables and values from the mojo (including its superclasses)
+ * Convenience method to obtain all variables and values from the mojo (including its superclasses)
*
* Note: the values in the map are of type Object so the caller is responsible for casting to desired types.
*
@@ -337,7 +337,7 @@
}
/**
- * convience method to obtain all variables and values from the mojo (including its superclasses)
+ * Convenience method to obtain all variables and values from the mojo (including its superclasses)
*
* Note: the values in the map are of type Object so the caller is responsible for casting to desired types.
*
@@ -373,7 +373,8 @@
}
/**
- * convience method to set values to variables in objects that don't have setters
+ * Convenience method to set values to variables in objects that don't have setters
+ *
* @param object
* @param variable
* @param value
@@ -417,20 +418,14 @@
{
throw new Exception( "unable to determine " + element );
}
- else
- {
- return elementDom.getValue();
- }
- }
- else
- {
- throw new Exception( "unable to determine " + element );
+
+ return elementDom.getValue();
}
+
+ throw new Exception( "unable to determine " + element );
}
- else
- {
- return elementDom.getValue();
- }
+
+ return elementDom.getValue();
}
/**
@@ -448,9 +443,7 @@
{
return;
}
- else
- {
- throw new Exception( "container is null, make sure super.setUp() is called" );
- }
+
+ throw new Exception( "container is null, make sure super.setUp() is called" );
}
}