You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by jpalermo <gi...@git.apache.org> on 2014/04/20 00:41:35 UTC
[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
GitHub user jpalermo opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/23
Change private CameraLauncher.java members to be protected
We're modifying a plugin to use most of the Camera plugin behavior on Android, but we want to override what happens inside of takePicture.
takePicture uses a number of private members, so overriding it means we need to copy the source for nearly everything into our subclass and then we loose a lot of the value we want from inheriting from CameraLauncher.
This changes all the members of CameraLauncher to be protected rather than private.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpalermo/cordova-plugin-camera-foreground protected_members
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
----
commit 0974898636dfa217b77362d0c8e8d9088f37cf39
Author: Joseph Palermo <jo...@daypalermo.com>
Date: 2014-04-18T17:41:12Z
Change private CameraLauncher.java members to be protected so inheritance is possible.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/23
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-47379219
Camera has a lot of technical debt and a lot of bugs in it. I think you'd actually be better off forking the plugin rather than extending it. Even better would be to re-write it and contribute it back! :)
Either way, I don't think making the fields protected is a good ideas since they will very likely be refactored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-camera pull request: Change private CameraLauncher....
Posted by jpalermo <gi...@git.apache.org>.
Github user jpalermo commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/23#issuecomment-46143691
Rebased the commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---