You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/04/24 19:21:18 UTC

[GitHub] [incubator-netbeans] matthiasblaesing commented on a change in pull request #1213: Making sure profiler.oql tests pass.

matthiasblaesing commented on a change in pull request #1213: Making sure profiler.oql tests pass.
URL: https://github.com/apache/incubator-netbeans/pull/1213#discussion_r278279254
 
 

 ##########
 File path: profiler/profiler.oql/test/unit/src/org/netbeans/modules/profiler/oql/engine/api/impl/OQLEngineTest.java
 ##########
 @@ -515,6 +516,7 @@ public boolean visit(Object o) {
                 return false;
             }
         });
+        output[0] = output[0].replaceAll("UID=301077366599181[0-9]*", "UID=301077366599181567");
 
 Review comment:
   Could you please add a comment what this making replacement does? Not so much for the change itself, as for future readers, that wonder what was this meant to say.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists