[GitHub] [tvm] lhutton1 commented on a diff in pull request #15147: [microNPU][ETHOSU] Add option to disable copying constants for case without cascader

["lhutton1 (via GitHub)" <gi...@apache.org>]

lhutton1 commented on code in PR #15147:
URL: https://github.com/apache/tvm/pull/15147#discussion_r1242287897


##########
src/relay/backend/contrib/ethosu/compiler_attrs.cc:
##########
@@ -59,6 +60,9 @@ struct EthosUCompilerConfigNode : public tvm::AttrsNode<EthosUCompilerConfigNode
     TVM_ATTR_FIELD(enable_cascader)
         .describe("Whether the cascader should be enabled")
         .set_default(false);
+    TVM_ATTR_FIELD(disable_copying_constants)
+        .describe("Whether copying constants is disabled for case without cascader")

Review Comment:
   Perhaps it's worth mentioning here that constants are expected to be in SRAM when this option is enabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org