You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2020/08/21 18:17:00 UTC

[jira] [Commented] (CASSANDRA-11402) Alignment wrong in tpstats output for PerDiskMemtableFlushWriter and format to YAML is broken

    [ https://issues.apache.org/jira/browse/CASSANDRA-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182056#comment-17182056 ] 

Stefan Miklosovic commented on CASSANDRA-11402:
-----------------------------------------------

I hijacked this issue as I was checking if there is already some and this one seems to be the most similar.

Besides of rewriting TPStats to use TableBuilder, there is a bug when -F yaml is introduced as it can to output that as YAML due to the fact that dump can not process arrays of primitives and it throws an exception hence as of now (trunk), tpstats in YAML are broken.

The PR fixes it both.

> Alignment wrong in tpstats output for PerDiskMemtableFlushWriter and format to YAML is broken
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11402
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11402
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joel Knighton
>            Assignee: Stefan Miklosovic
>            Priority: Low
>              Labels: lhf
>             Fix For: 3.11.x
>
>         Attachments: 11402-3_5_patch1.patch, 11402-trunk.txt
>
>
> With the accompanying designation of which memtableflushwriter it is, this threadpool name is too long for the hardcoded padding in tpstats output.
> We should dynamically calculate padding so that we don't need to check this every time we add a threadpool.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org