You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2017/11/16 00:41:00 UTC

[jira] [Created] (HBASE-19275) TestSnapshotFileCache never worked properly

Andrew Purtell created HBASE-19275:
--------------------------------------

             Summary: TestSnapshotFileCache never worked properly
                 Key: HBASE-19275
                 URL: https://issues.apache.org/jira/browse/HBASE-19275
             Project: HBase
          Issue Type: Bug
    Affects Versions: 2.0.0, 3.0.0, 1.4.0, 1.5.0
            Reporter: Andrew Purtell


Error-prone noticed we were asking Iterables.contains() questions with the wrong type. I've attached a fixed version of the test. The results suggest the cache is not evicting entries properly. 

{noformat}
java.lang.AssertionError: Cache found 'hdfs://localhost:52867/user/apurtell/test-data/8ce04c85-ce4b-4844-b454-5303482ade95/data/default/snapshot1/9e49edd0ab41657fb0c6ebb4d9dfad15/cf/f132e5b06f66443f8003363ed1535aac', but it shouldn't have.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshot(TestSnapshotFileCache.java:260)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshotV1(TestSnapshotFileCache.java:206)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testReloadModifiedDirectory(TestSnapshotFileCache.java:102)
{noformat}


{noformat}
java.lang.AssertionError: Cache found 'hdfs://localhost:52867/user/apurtell/test-data/8ce04c85-ce4b-4844-b454-5303482ade95/data/default/snapshot1a/2e81adb9212c98cff970eafa006fc40b/cf/a2ec478d850e4e348359699c53b732c4', but it shouldn't have.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.junit.Assert.assertFalse(Assert.java:64)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshot(TestSnapshotFileCache.java:260)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.createAndTestSnapshotV1(TestSnapshotFileCache.java:206)
	at org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache.testLoadAndDelete(TestSnapshotFileCache.java:88)
{noformat}

These changes are part of HBASE-19239

I've disabled the offending test cases with @Ignore in that patch, but they should be reenabled and fixed. 




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)