You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/12/14 02:27:33 UTC

[GitHub] wenfengwang commented on a change in pull request #12: [WIP]More Configurable fields and mores

wenfengwang commented on a change in pull request #12: [WIP]More Configurable fields and mores
URL: https://github.com/apache/rocketmq-client-go/pull/12#discussion_r241627870
 
 

 ##########
 File path: core/api.go
 ##########
 @@ -23,20 +23,31 @@ func Version() (version string) {
 }
 
 // NewProduer create a new producer with config
-func NewProduer(config *ProducerConfig) Producer {
+func NewProduer(config *ProducerConfig) (Producer, error) {
 
 Review comment:
   The PR is working in process, i will rebase `master` branch after previous PR merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services