You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by "Dongjoon Hyun (Jira)" <ji...@apache.org> on 2023/01/09 23:24:00 UTC

[jira] [Resolved] (ORC-1348) TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>

     [ https://issues.apache.org/jira/browse/ORC-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dongjoon Hyun resolved ORC-1348.
--------------------------------
    Fix Version/s: 1.9.0
                       (was: master)
         Assignee: Junwang Zhao
       Resolution: Fixed

This is resolved via https://github.com/apache/orc/pull/1358 .

cc [~wgtmac] (I resolved this issue since the PR is merged)

> TimezoneImpl constructor should pass std::vector<> & instead of std::vector<>
> -----------------------------------------------------------------------------
>
>                 Key: ORC-1348
>                 URL: https://issues.apache.org/jira/browse/ORC-1348
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: master
>            Reporter: Junwang Zhao
>            Assignee: Junwang Zhao
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes) should
> change to TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes) to reduce copy constructor of vector of unsigned char.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)