You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ab...@apache.org on 2013/10/01 23:36:57 UTC

git commit: Fix assertEquals arg ordering in BaseSecurityGroupExtensionLiveTest

Updated Branches:
  refs/heads/master 6eda031e2 -> d6830bd5f


Fix assertEquals arg ordering in BaseSecurityGroupExtensionLiveTest


Project: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/commit/d6830bd5
Tree: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/tree/d6830bd5
Diff: http://git-wip-us.apache.org/repos/asf/incubator-jclouds/diff/d6830bd5

Branch: refs/heads/master
Commit: d6830bd5ff8da00ab3c4c9876c85f47f04a27ac7
Parents: 6eda031
Author: Andrew Bayer <an...@gmail.com>
Authored: Tue Oct 1 14:36:34 2013 -0700
Committer: Andrew Bayer <an...@gmail.com>
Committed: Tue Oct 1 14:36:48 2013 -0700

----------------------------------------------------------------------
 .../internal/BaseSecurityGroupExtensionLiveTest.java           | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-jclouds/blob/d6830bd5/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java
----------------------------------------------------------------------
diff --git a/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java b/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java
index 3f775d2..022b670 100644
--- a/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java
+++ b/compute/src/test/java/org/jclouds/compute/extensions/internal/BaseSecurityGroupExtensionLiveTest.java
@@ -137,7 +137,8 @@ public abstract class BaseSecurityGroupExtensionLiveTest extends BaseComputeServ
 
       SecurityGroup newGroup = securityGroupExtension.get().addIpPermission(perm, group);
 
-      assertEquals(perm, Iterables.getOnlyElement(newGroup.getIpPermissions())); 
+      assertEquals(Iterables.getOnlyElement(newGroup.getIpPermissions()), perm,
+              "Expecting IpPermission " + perm + " but group was " + newGroup);
    }
    
    @Test(groups = { "integration", "live" }, singleThreaded = true, dependsOnMethods = "testAddIpPermission")
@@ -165,7 +166,8 @@ public abstract class BaseSecurityGroupExtensionLiveTest extends BaseComputeServ
 
       SecurityGroup newGroup = securityGroupExtension.get().removeIpPermission(perm, group);
 
-      assertEquals(0, Iterables.size(newGroup.getIpPermissions())); 
+      assertEquals(Iterables.size(newGroup.getIpPermissions()), 0,
+              "Group should have no permissions, but has " + Iterables.size(newGroup.getIpPermissions()));
    }
 
    @Test(groups = { "integration", "live" }, singleThreaded = true, dependsOnMethods = "testRemoveIpPermission")