You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/08 06:42:14 UTC

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Pearl1594 opened a new pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517


   Addresses : https://github.com/apache/cloudstack-primate/issues/511


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655334577






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655325355


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/517 (JID-2254)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655321561


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#discussion_r451325926



##########
File path: src/components/view/DetailSettings.vue
##########
@@ -173,7 +173,8 @@ export default {
     },
     isAdminOrOwner () {
       return ['Admin'].includes(this.$store.getters.userInfo.roletype) ||
-        (this.resource.domainid === this.$store.getters.userInfo.domainid && this.resource.account === this.$store.getters.userInfo.account)
+        (this.resource.domainid === this.$store.getters.userInfo.domainid && this.resource.account === this.$store.getters.userInfo.account) ||
+        this.resource.project && this.resource.project === this.$store.getters.project.name

Review comment:
       @Pearl1594 should the check be on projectid instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655338733


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/517 (JID-2256)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655321304


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517#issuecomment-655335111


   @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #517: Allows viewing delete/copy iso/template buttons for non ready resources and enables settings

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #517:
URL: https://github.com/apache/cloudstack-primate/pull/517


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org