You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Konrad Windszus (Jira)" <ji...@apache.org> on 2021/03/09 15:43:00 UTC
[jira] [Commented] (JCRVLT-510) Clarify meaning of
ImportOptions.isStrict()
[ https://issues.apache.org/jira/browse/JCRVLT-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298126#comment-17298126 ]
Konrad Windszus commented on JCRVLT-510:
----------------------------------------
IMHO {{strict}} should be deprecated and no longer be evaluated. Especially as with {{PackageRegistry}} the {{ImportOptions}} can no longer be influenced and the default value is {{false}}.
All exceptions should bubble up to the caller. A best effort installation is in most cases not desired as it may lead to subtle errors which easily might not get noticed.
> Clarify meaning of ImportOptions.isStrict()
> -------------------------------------------
>
> Key: JCRVLT-510
> URL: https://issues.apache.org/jira/browse/JCRVLT-510
> Project: Jackrabbit FileVault
> Issue Type: Improvement
> Reporter: Konrad Windszus
> Priority: Major
>
> Currently there is no clear description what the strict flag (https://github.com/apache/jackrabbit-filevault/blob/f91c3d73ab33e4155837768d70b7c3e8c7da9e2d/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/ImportOptions.java#L130) means.
> The following places currently evaluate it:
> # Defer throwing non-fatal exception during import (https://github.com/apache/jackrabbit-filevault/blob/f785fcb24d4cbd01c734e9273310a925c29ae15b/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/ZipVaultPackage.java#L269), i.e. used with ACL/Authorizable import issues (compare with JCRVLT-509)
> # When cyclic dependencies are detected: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L486
> # During uninstallation of packages: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/packaging/impl/JcrPackageImpl.java#L990
> # During installation of node types: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L531
> # During installation of privileges: https://github.com/apache/jackrabbit-filevault/blob/1dc01f131f42306e8bc6898ba112c8b53475933c/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L549
--
This message was sent by Atlassian Jira
(v8.3.4#803005)