You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by yo...@apache.org on 2022/11/28 09:13:03 UTC

[superset] branch master updated: fix: the TimePicker overlay the AdhocFilter (#22234)

This is an automated email from the ASF dual-hosted git repository.

yongjiezhao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 0fdc520797 fix: the TimePicker overlay the AdhocFilter (#22234)
0fdc520797 is described below

commit 0fdc52079704ae33ab59385b789b9c4768e8ca63
Author: Yongjie Zhao <yo...@gmail.com>
AuthorDate: Mon Nov 28 17:12:40 2022 +0800

    fix: the TimePicker overlay the AdhocFilter (#22234)
---
 .../explore/components/controls/DateFilterControl/DateFilterLabel.tsx  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
index 0f7993f5c1..c68b436a0e 100644
--- a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
+++ b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx
@@ -343,13 +343,14 @@ export default function DateFilterLabel(props: DateFilterControlProps) {
           {actualTimeRange}
         </Label>
       </Tooltip>
+      {/* the zIndex value is from trying so that the Modal doesn't overlay the AdhocFilter when GENERIC_CHART_AXES is enabled */}
       <Modal
         title={title}
         show={show}
         onHide={toggleOverlay}
         width="600px"
         hideFooter
-        zIndex={Number.MAX_SAFE_INTEGER}
+        zIndex={1030}
       >
         {overlayContent}
       </Modal>