You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by gaohoward <gi...@git.apache.org> on 2018/10/19 13:46:48 UTC
[GitHub] activemq-artemis pull request #2383: NO-JIRA Adding a test for ARTEMIS-2096
GitHub user gaohoward opened a pull request:
https://github.com/apache/activemq-artemis/pull/2383
NO-JIRA Adding a test for ARTEMIS-2096
This test can verify an issue fixed by the commit:
7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096)
The issue was reported in:
https://issues.jboss.org/browse/ENTMQBR-2034
but not reported in Artemis.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gaohoward/activemq-artemis c_2034
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2383.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2383
----
commit 89ef072d80d6d034be73244af05617b2bf3baf36
Author: Howard Gao <ho...@...>
Date: 2018-10-19T13:40:33Z
NO-JIRA Adding a test for ARTEMIS-2096
This test can verify an issue fixed by the commit:
7a463f038ae324f2c5c908321b2ebf03b5a8e303 (ARTEMIS-2096)
The issue was reported in:
https://issues.jboss.org/browse/ENTMQBR-2034
but not reported in Artemis.
----
---
[GitHub] activemq-artemis issue #2383: ARTEMIS-2096 Adding a test
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
@clebertsuconic I'll send a PR to 2.6.x but not cherry-pick from this. Because on 2.6.x the fix is by a different commit not the one I mentioned here.
---
[GitHub] activemq-artemis issue #2383: NO-JIRA Adding a test for ARTEMIS-2096
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
agreed I'll remove the NO-JIRA. thx.
---
[GitHub] activemq-artemis issue #2383: ARTEMIS-2096 Adding a test
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
@gaohoward
- I wouldn't mention external JIRAs here...
- Please find a more inclusive message.. when I do git log, a message such as "Adding a Test" doesn't help much.
---
[GitHub] activemq-artemis issue #2383: ARTEMIS-2096 Adding a test
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
ok will do.
---
[GitHub] activemq-artemis issue #2383: NO-JIRA Adding a test for ARTEMIS-2096
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
This isn't really a NO-JIRA commit if you are adding a test against a specific JIRA is it? No reason I can see to put a NO-JIRA on this instead of just tagging against the JIRA that it is related to.
---
[GitHub] activemq-artemis pull request #2383: ARTEMIS-2096 Adding a test
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2383
---
[GitHub] activemq-artemis issue #2383: ARTEMIS-2096 Adding a test
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2383
@gaohoward this is actually ARTEMIS-2135, which I fixed in 2.6.x and added a test.
Also verified that @tabish121 ' s refactoring fixed it.. but the actual issue for this test is ARTEMIS-2135.
Which I had already fixed in 48e0fc8f42346d96bc809593a150e05a586787ee at 2.6.x.
---