You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/12/05 16:05:29 UTC
[GitHub] [incubator-kvrocks] git-hulk opened a new pull request, #1162: Fix don't append the ERR prefix in no script error
git-hulk opened a new pull request, #1162:
URL: https://github.com/apache/incubator-kvrocks/pull/1162
This closes #1161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk merged pull request #1162: Fix wrongly append the ERR prefix in no script error
Posted by GitBox <gi...@apache.org>.
git-hulk merged PR #1162:
URL: https://github.com/apache/incubator-kvrocks/pull/1162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1162: Fix wrongly append the ERR prefix in no script error
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1162:
URL: https://github.com/apache/incubator-kvrocks/pull/1162#issuecomment-1338615717
Thanks all, merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #1162: Fix wrongly append the ERR prefix in no script error
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #1162:
URL: https://github.com/apache/incubator-kvrocks/pull/1162#issuecomment-1337665839
> Although return `Status::Ok` with a `Redis::Error` payload seems weird, this patch fixes the issue.
>
> +1 for merge.
Yes, we are mixed using the status message and error output in many places. But we can unify them in the next PR if it's confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org