You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/03/09 07:45:06 UTC
[GitHub] zeppelin pull request #2853: [ZEPPELIN-3306] Web e2e test fails
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2853
[ZEPPELIN-3306] Web e2e test fails
### What is this PR for?
This is one of the flaky tests that fails with "should have a welcome message" because Z-Server did not start by the time test started executing.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3306](https://issues.apache.org/jira/browse/ZEPPELIN-3306)
### How should this be tested?
* CI should pass
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3306
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2853
----
commit 8742b1104f7d3671d33343006a25decf9618f79b
Author: Prabhjyot Singh <pr...@...>
Date: 2018-03-09T07:42:12Z
ZEPPELIN-3306: Web e2e test fails
Change-Id: If29e84e5ff2b3bf06dbf624d6baab87b6b9f38c4
----
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2853
Will merge this soon.
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2853
CI green https://travis-ci.org/prabhjyotsingh/zeppelin/builds/351259448.
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2853
@zjffdu
Can you help review this? Looks like this was actually because of the latest version of chrome (65.0.3325.146) and had to update webdriver-manager's chrome version.
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2853
Thanks @prabhjyotsingh , LGTM, the selenium test still fails due to corrupted scala jars, could you clean travis cache and rebuild it again to make sure all the test pass ?
---
[GitHub] zeppelin pull request #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2853
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2853
@felixcheung it doesn't happen always but at times before could Zeppelin-server start test case starts executing, and by making `spawn="false"` maven waits for the command (./bin/zeppelin-daemon.sh start) to complete, and `CI=true` make zeppelin-daemon to wait for localhost:8080 to be active.
---
[GitHub] zeppelin issue #2853: [ZEPPELIN-3306] Web e2e test fails
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2853
Awesome, thanks @prabhjyotsingh
---