You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/03/15 23:06:28 UTC
Re: Review Request: AllocatorTest refactor for consistency
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/
-----------------------------------------------------------
(Updated March 15, 2013, 10:06 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added a bunch of comments explaining the tests. There is still no change in functionality, so it should be very easy to review and commit.
Description
-------
Refactor of the AllocatorTests so that all Triggers use the -Call convention.
Also removes the code for checkResources which was removed from use in a previous patch.
This used to be part of the static allocator review, but has been separated out to make reviewing easier.
Diffs (updated)
-----
src/tests/allocator_tests.cpp b953cd1
src/tests/allocator_zookeeper_tests.cpp 3f70202
Diff: https://reviews.apache.org/r/9407/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: AllocatorTest refactor for consistency
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 21, 2013, 1:23 a.m., Benjamin Hindman wrote:
> > This is awesome, thanks for this Thomas!
Can you rebase this so we can get it applied?
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/#review18191
-----------------------------------------------------------
On March 15, 2013, 10:06 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9407/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 10:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Refactor of the AllocatorTests so that all Triggers use the -Call convention.
>
> Also removes the code for checkResources which was removed from use in a previous patch.
>
> This used to be part of the static allocator review, but has been separated out to make reviewing easier.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp b953cd1
> src/tests/allocator_zookeeper_tests.cpp 3f70202
>
> Diff: https://reviews.apache.org/r/9407/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: AllocatorTest refactor for consistency
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/#review18191
-----------------------------------------------------------
Ship it!
This is awesome, thanks for this Thomas!
- Benjamin Hindman
On March 15, 2013, 10:06 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9407/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 10:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Refactor of the AllocatorTests so that all Triggers use the -Call convention.
>
> Also removes the code for checkResources which was removed from use in a previous patch.
>
> This used to be part of the static allocator review, but has been separated out to make reviewing easier.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp b953cd1
> src/tests/allocator_zookeeper_tests.cpp 3f70202
>
> Diff: https://reviews.apache.org/r/9407/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: AllocatorTest refactor for consistency
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/#review18225
-----------------------------------------------------------
Ship it!
Loved the comments. I think you have set the bar high for the rest of us test writers :) Thank you!
- Vinod Kone
On March 21, 2013, 7:08 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9407/
> -----------------------------------------------------------
>
> (Updated March 21, 2013, 7:08 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Refactor of the AllocatorTests so that all Triggers use the -Call convention.
>
> Also removes the code for checkResources which was removed from use in a previous patch.
>
> This used to be part of the static allocator review, but has been separated out to make reviewing easier.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp e8b835f
> src/tests/allocator_zookeeper_tests.cpp 802a508
>
> Diff: https://reviews.apache.org/r/9407/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: AllocatorTest refactor for consistency
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9407/
-----------------------------------------------------------
(Updated March 21, 2013, 7:08 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Updated to trunk.
Description
-------
Refactor of the AllocatorTests so that all Triggers use the -Call convention.
Also removes the code for checkResources which was removed from use in a previous patch.
This used to be part of the static allocator review, but has been separated out to make reviewing easier.
Diffs (updated)
-----
src/tests/allocator_tests.cpp e8b835f
src/tests/allocator_zookeeper_tests.cpp 802a508
Diff: https://reviews.apache.org/r/9407/diff/
Testing
-------
make check
Thanks,
Thomas Marshall