You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Stan Lewis (JIRA)" <ji...@apache.org> on 2009/11/05 21:44:53 UTC
[jira] Created: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
--------------------------------------------------------------------------------------
Key: CAMEL-2138
URL: https://issues.apache.org/activemq/browse/CAMEL-2138
Project: Apache Camel
Issue Type: Improvement
Components: camel-http
Affects Versions: 2.0.0
Reporter: Stan Lewis
Priority: Minor
Attachments: patch.txt
To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55195#action_55195 ]
Willem Jiang commented on CAMEL-2138:
-------------------------------------
@Stan,
I just commit a quick fix[1] for your patch, please feel free to do some enhancement on the Host part and tests :)
[1] http://svn.apache.org/viewvc?rev=833350&view=rev
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55186#action_55186 ]
Claus Ibsen commented on CAMEL-2138:
------------------------------------
Ah Stan to be 100% sure if I still want to use Basic I just only supply username and password.
But for NT I *have* to supply domain as well?
Stan do you mind updating the wiki page for camel-http?
http://camel.apache.org/http
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stan Lewis updated CAMEL-2138:
------------------------------
Attachment: patch.txt
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55191#action_55191 ]
Claus Ibsen commented on CAMEL-2138:
------------------------------------
Wiilem are you fixing this?
I am bitten by this now working on another ticket
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2138:
-------------------------------
Fix Version/s: 2.1.0
1.6.2
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.1.0
>
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55192#action_55192 ]
Willem Jiang commented on CAMEL-2138:
-------------------------------------
Yes, I'm working on this now.
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-2138.
--------------------------------
Resolution: Fixed
I added wiki documentation about the new domain option.
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 1.6.2, 2.1.0
>
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Stan Lewis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55194#action_55194 ]
Stan Lewis commented on CAMEL-2138:
-----------------------------------
Interesting, the HttpClient docs stated that NTCredentials could just be used in place of UsernamePasswordCredentials. But there's no tests in place for any of this. I'll try and add some tests for this today.
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55190#action_55190 ]
Willem Jiang commented on CAMEL-2138:
-------------------------------------
I just found the NTCredential and UsernamePasswordCredentials aren't interchangeable.
As NTCredential can't accept null of the Domain and Host in it's construction
{code}
public NTCredentials(String userName, String password, String host,
String domain) {
super(userName, password);
if (domain == null) {
throw new IllegalArgumentException("Domain may not be null");
}
this.domain = domain;
if (host == null) {
throw new IllegalArgumentException("Host may not be null");
}
this.host = host;
}
{code}
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2138) Use NTCredentials instead of
UsernamePasswordCredentials for HttpClient authentication
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-2138:
-----------------------------------
Assignee: Willem Jiang
> Use NTCredentials instead of UsernamePasswordCredentials for HttpClient authentication
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-2138
> URL: https://issues.apache.org/activemq/browse/CAMEL-2138
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-http
> Affects Versions: 2.0.0
> Reporter: Stan Lewis
> Assignee: Willem Jiang
> Priority: Minor
> Attachments: patch.txt
>
>
> To use NTLM with HttpClient you've got to supply NTCredentials instead of UsernamePasswordCredentials. Luckily they're interchangeable, this patch changes that and adds a "domain" and a "proxyDomain" option so users can supply their NT domain to either the proxy or the server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.