You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 13:05:19 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #25249: Add outlet_datasets to tasks endpoints

dstandish commented on code in PR #25249:
URL: https://github.com/apache/airflow/pull/25249#discussion_r928861034


##########
tests/api_connexion/endpoints/test_task_endpoint.py:
##########
@@ -332,6 +336,7 @@ def test_get_tasks_mapped(self):
                     "execution_timeout": None,
                     "extra_links": [],
                     "is_mapped": True,
+                    # todo: should be "outlet_datasets": [], but does not work for mapped

Review Comment:
   fundamentally, it doesn't make sense to not support datasets just because a task is mapped.  that sorta means mapped tasks aren't first class citizens.  with mapped tasks, we'll soon be able to create "map kwargs" essentially (so iterating over list(dict) instead of list(primitive), which i think should unlock mapping the outlets param too?  i dunno. it needs thought.  but, just doesn't seem right for it to not be supported, for a datasets API -- are mapped tasks not supposed to also be used for data?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org