You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Sunyue (via GitHub)" <gi...@apache.org> on 2026/01/15 08:18:43 UTC

[I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Sunyue opened a new issue, #635:
URL: https://github.com/apache/arrow-go/issues/635

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   Hi @zeroshade I see you have upgraded  `substrait-go` to `7.2.2`, I think this can cause some breaking change.
   This not only affect string/binary comparison as you detected here https://github.com/apache/arrow-go/pull/612/files, but also affect numeric comparison like int64/uint8 which is working as of now.
   This is especially a problem as types like uint8 is not supported by `subtrait`, previously we can convert uint8 to int64 to perform the compare, what's the solution when using `substrait-go 7.22` ? Thanks.
   
   Example scenario: use `arrow/compute` and `arrow/compute/exprs` to filter values from an arrow table, the filter is set on column with type `arrow.UINT8`
   
   ### Component(s)
   
   Other


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Posted by "Sunyue (via GitHub)" <gi...@apache.org>.
Sunyue commented on issue #635:
URL: https://github.com/apache/arrow-go/issues/635#issuecomment-3839673984

   Hi @zeroshade, sorry for the late reply, I had a try with CAST and it should cover most of the cases. The edge case is, e.g I have a arrow record which has a column uint64 and I want to build an expression to filter record > uint64(n), where n > 9223372036854775807. In that case, I can't create a Literal with type uint64 nor int64. Do you know if there is any way to cover such scenario? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #635:
URL: https://github.com/apache/arrow-go/issues/635#issuecomment-4380660943

   I believe we have user-defined types to cover this for our substrait usage. Can you confirm?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #635:
URL: https://github.com/apache/arrow-go/issues/635#issuecomment-5501437303

   Closing this as stale — the version this was filed against is several majors behind now.
   
   arrow-go is on `substrait-io/substrait-go/v8 v8.1.1` on main, versus the v7.2.2 discussed here. Unsigned Arrow types are given Substrait user-defined extension types (`arrow/compute/exprs/types.go`), so `arrow.UINT8` comparisons should work with an explicit CAST, which you confirmed covers most of your cases.
   
   The one open thread was the `uint64` literal above `math.MaxInt64` edge case, where I asked whether the user-defined types covered it (https://github.com/apache/arrow-go/issues/635#issuecomment-2813237723-style follow-up on 2026-05-05) and we didn't hear back.
   
   @Sunyue if that edge case is still a problem on v8, please open a fresh issue with a small reproducer against the current release — a new issue will get better attention than this one, since the v7 context no longer applies. Thanks for the original report.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #635:
URL: https://github.com/apache/arrow-go/issues/635#issuecomment-3761873562

   All of the unsigned types are given substrait extension types so that we can still use them for substrait expressions via arrow-go. You'll likely need to just use an explicit CAST function instead of implicit though for the comparison to continue to work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Breaking change from github.com/substrait-io/substrait-go/v7 7.2.2 [arrow-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #635: Breaking change from github.com/substrait-io/substrait-go/v7  7.2.2
URL: https://github.com/apache/arrow-go/issues/635


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org