You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 07:14:49 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on a change in pull request #1483: support comparison for decimal data type and refactor the binary coercion rule

liukun4515 commented on a change in pull request #1483:
URL: https://github.com/apache/arrow-datafusion/pull/1483#discussion_r775367644



##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -501,58 +706,6 @@ macro_rules! compute_utf8_flag_op_scalar {
     }};
 }
 
-/// Coercion rules for all binary operators. Returns the output type
-/// of applying `op` to an argument of `lhs_type` and `rhs_type`.
-fn common_binary_type(

Review comment:
       move the main code to the file of `binary_rule.rs`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org