You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "alex-grisham (GitHub)" <gi...@apache.org> on 2019/08/14 20:49:28 UTC

[GitHub] [geode] alex-grisham opened pull request #3927: GEODE-6805: Allow shorthand ~ to represent user home in jar deployment.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3927 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3927: GEODE-6805: Allow shorthand ~ to represent user home in jar deployment.

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
Add a test that `--jar=~foo/bar.jar` and `--jar=foo~/bar.jar` are not modified.

[ Full content available at: https://github.com/apache/geode/pull/3927 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #3927: GEODE-6805: Allow shorthand ~ to represent user home in jar deployment.

Posted by "pivotal-jbarrett (GitHub)" <gi...@apache.org>.
I don't think you intend for `/~/`, `f~oo`, or other combinations of `~` to be replaced. The `~` should only be replaced if it anchors the beginning of the path and is immediately followed by a path separator. Something like this regex `^~(?:\/)` (untested) should do the trick.

[ Full content available at: https://github.com/apache/geode/pull/3927 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3927: GEODE-6805: Allow shorthand ~ to represent user home in jar deployment.

Posted by "jdeppe-pivotal (GitHub)" <gi...@apache.org>.
Technically (at least considering shell semantics) `~foo` is legitimate (it expands to the home directory of the `foo` user if that user exists) but I don't think we should attempt to expand that.

[ Full content available at: https://github.com/apache/geode/pull/3927 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org