DO NOT REPLY [Bug 34996] New: - Appender.requiresLayout should be restored

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34996>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34996

           Summary: Appender.requiresLayout should be restored
           Product: Log4j
           Version: 1.3alpha
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Appender
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: carnold@apache.org


Appender.requiresLayout was removed in v 1.13 (2004/11/15) with the comment "The requiresLayout 
method is no longer used or needed".

The semantics of the method was questioned in:

http://marc.theaimsgroup.com/?l=log4j-dev&m=107335136020370&w=2
http://marc.theaimsgroup.com/?l=log4j-dev&m=108462510611389&w=2

Basically, though the method was called "requiresLayout", the JavaDoc was more consistent with 
"acceptsLayout".  However, the number of appenders where that makes a difference should be fairly 
small.

My proposal is to restore Appender.requiresLayout and change the JavaDoc to be consistent with the 
name.  Concrete appenders appear to still have their implementation hanging around.  Though the 
configuration code no longer makes use of this property, it is conceivable that client code called this 
method and the cost of restoring it is low.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org