You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/08/10 16:54:30 UTC

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23276


Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................

[util] introduce security::IsFIPSEnabled()

This is a micro-refactoring regarding the FIPS provider status in
the OpenSSL: the duplicate code is replaced with newly introduced
security::IsFIPSEnabled() utility function.  For details on the
evolution of the FIPS-related terminology in the OpenSSL, see [1].

This is a follow-up to acac73ecda83ec2390b5990cc132ca6968bfefdf.

[1] https://github.com/openssl/openssl/discussions/21797

Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/openssl_util.cc
M src/kudu/util/openssl_util.h
4 files changed, 24 insertions(+), 27 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/23276/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1678/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 02:06:16 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1678/


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 00:50:43 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 12 Aug 2025 04:22:45 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23276

to look at the new patch set (#2).

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................

[util] introduce security::IsFIPSEnabled()

This is a micro-refactoring regarding the FIPS provider status in
the OpenSSL: the duplicate code is replaced with newly introduced
security::IsFIPSEnabled() utility function.  For details on the
evolution of the FIPS-related terminology in the OpenSSL, see [1].

This is a follow-up to acac73ecda83ec2390b5990cc132ca6968bfefdf.

[1] https://github.com/openssl/openssl/discussions/21797

Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/openssl_util.cc
M src/kudu/util/openssl_util.h
4 files changed, 24 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/23276/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................

[util] introduce security::IsFIPSEnabled()

This is a micro-refactoring regarding the FIPS provider status in
the OpenSSL: the duplicate code is replaced with newly introduced
security::IsFIPSEnabled() utility function.  For details on the
evolution of the FIPS-related terminology in the OpenSSL, see [1].

This is a follow-up to acac73ecda83ec2390b5990cc132ca6968bfefdf.

[1] https://github.com/openssl/openssl/discussions/21797

Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Reviewed-on: http://gerrit.cloudera.org:8080/23276
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/openssl_util.cc
M src/kudu/util/openssl_util.h
4 files changed, 24 insertions(+), 27 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Abhishek Chennaka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1674/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 10 Aug 2025 17:01:45 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 2: Verified+1

unrelated failures if known flaky tests:
  * RELEASE: org.apache.kudu.spark.kudu.DefaultSourceTest, org.apache.kudu.backup.TestKuduBackup
  * ASAN: org.apache.kudu.backup.TestKuduBackup
  * TSAN: KUDU-3660, org.apache.kudu.client.TestKuduClient,


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 11 Aug 2025 02:14:56 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce security::IsFIPSEnabled()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23276 )

Change subject: [util] introduce security::IsFIPSEnabled()
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1674/


-- 
To view, visit http://gerrit.cloudera.org:8080/23276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I672cb90af37d66468c1e2144da224e7795e75084
Gerrit-Change-Number: 23276
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 10 Aug 2025 16:54:36 +0000
Gerrit-HasComments: No