You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/05/07 11:44:59 UTC

[GitHub] [spark] MaxGekk opened a new pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

MaxGekk opened a new pull request #28475:
URL: https://github.com/apache/spark/pull/28475


   ## What changes were proposed in this pull request?
   
   The `DateTimeUtils.toMillis` can produce inaccurate result for some negative values (timestamps before epoch). The error can be around 1ms. In the PR, I propose to use `Math.floorDiv` in casting microseconds to milliseconds, and milliseconds to days since epoch.
   
   ## How was this patch tested?
   
   Added new test to `DateTimeUtilsSuite`, and tested by `CastSuite` as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625205948






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625205948






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625205314


   **[Test build #122401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122401/testReport)** for PR 28475 at commit [`f6e2e72`](https://github.com/apache/spark/commit/f6e2e720f403ff5779ec736e2625bbc5add2d631).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625205314


   **[Test build #122401 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122401/testReport)** for PR 28475 at commit [`f6e2e72`](https://github.com/apache/spark/commit/f6e2e720f403ff5779ec736e2625bbc5add2d631).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625309314


   thanks, merging to 2.4!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625305843


   **[Test build #122401 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/122401/testReport)** for PR 28475 at commit [`f6e2e72`](https://github.com/apache/spark/commit/f6e2e720f403ff5779ec736e2625bbc5add2d631).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] MaxGekk commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625204951


   @cloud-fan @HyukjinKwon This is a backport of https://github.com/apache/spark/pull/23815 which fixes some bugs, see the tests.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625306474






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #28475: [SPARK-26908][SQL][2.4] Fix DateTimeUtils.toMillis and millisToDays

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28475:
URL: https://github.com/apache/spark/pull/28475#issuecomment-625306474






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org