You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mel Martinez <me...@yahoo.com> on 2001/03/05 00:01:20 UTC

[PATCH][tc3.3]Re: Proposed ApacheConfig.java change

The attached PATCH modifies 
org.apache.tomcat.modules.config.ApacheConfig to add
some needed flexibility.  I need someone who is
running apache and tomcat3.3 using mod_jserv to test
it in that 
configuration and give their feedback.

I've tested it with mod_jk on winNT and linux 6.2 and
it seems to work fine.  I would of course welcome any
tests that would uncover things I may have overlooked.
 As soon as I have a reasonable amount of feedback to
resolve any such oversights, I will commit the
changes.

The nature of the changes is as follows.  First off, 
if you haven't been using the latest tomcat3.3, you
need to tell it to auto-generate the Apache config
files for jserv and jk. To do this, the only thing you
need to do is insert an <ApacheConfig/> config
intercepter element inside the ContextManager tag like
so:

<ContextManager ... >
  ...
  <ApacheConfig />
  ...
</ContextManager>

That will make sure that ApacheConfig is invoked.

In the absence of any attributes in the
<ApacheConfig/> 
tag the only difference in behavior should be that the
LoadModule statements will be wrapped in 
<IfModule !mod_name.c>
...
</IfModule> 
tags to make the loads conditional.

In addition to making the LoadModule
statements conditional, I've also added some
attributes to the <ApacheConfig /> tag that should
greatly 
help setting up Apache and Tomcat deployments:

confighome - default parent directory for the
following  
  paths. If not set, this defaults to TOMCAT_HOME.
  Ignored whenever any of the following paths is
  absolute. 
     
jservconfig - path to write apache jserv conf file to.
  If not set, defaults to
  "conf/jserv/tomcat-apache.conf". 
     
jkconfig - path to write apacke mod_jk conf file to.
  If not set, defaults to "conf/jk/mod_jk.conf".

workersconfig - path to workers.properties file used
  by mod_jk. If not set, defaults to
  "conf/jk/workers.properties". 

modjserv - path to Apache JServ plugin module file.
  If not set, defaults to
  "modules/ApacheModuleJServ.dll" on windows, 
  "modules/Jserv.nlm" on netware, and
  "libexec/mod_jserv.so" everywhere else. 
  
modjk - path to Apache mod_jk plugin file. If not
   set, defaults to "modules/mod_jk.dll" on windows,
   "modules/mod_jk.nlm" on netware, and
   "libexec/mod_jk.so" everywhere else. 

jklog - path to log file to be used by mod_jk. 

All of these attributes are optional.

Please try the patch out and let me know if you have
any problems.

Send me a +1 if you think it should be committed.

Cheers,

Mel


__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/

[PATCH][tc3.3]Re: Proposed ApacheConfig.java change

Posted by Mel Martinez <me...@yahoo.com>.
{sorry about the resend - I hit the send button early
last time}
The attached PATCH modifies 
org.apache.tomcat.modules.config.ApacheConfig to add
some needed flexibility.  I need someone who is
running apache and tomcat3.3 using mod_jserv to test
it in that 
configuration and give their feedback.

I've tested it with mod_jk on winNT and linux 6.2 and
it seems to work fine.  I would of course welcome any
tests that would uncover things I may have overlooked.
 As soon as I have a reasonable amount of feedback to
resolve any such oversights, I will commit the
changes.

The nature of the changes is as follows.  First off, 
if you haven't been using the latest tomcat3.3, you
need to tell it to auto-generate the Apache config
files for jserv and jk. To do this, the only thing you
need to do is insert an <ApacheConfig/> config
intercepter element inside the ContextManager tag like
so:

<ContextManager ... >
  ...
  <ApacheConfig />
  ...
</ContextManager>

That will make sure that ApacheConfig is invoked.

In the absence of any attributes in the
<ApacheConfig/> 
tag the only difference in behavior should be that the
LoadModule statements will be wrapped in 
<IfModule !mod_name.c>
...
</IfModule> 
tags to make the loads conditional.

In addition to making the LoadModule
statements conditional, I've also added some
attributes to the <ApacheConfig /> tag that should
greatly 
help setting up Apache and Tomcat deployments:

confighome - default parent directory for the
following  
  paths. If not set, this defaults to TOMCAT_HOME.
  Ignored whenever any of the following paths is
  absolute. 
     
jservconfig - path to write apache jserv conf file to.
  If not set, defaults to
  "conf/jserv/tomcat-apache.conf". 
     
jkconfig - path to write apacke mod_jk conf file to.
  If not set, defaults to "conf/jk/mod_jk.conf".

workersconfig - path to workers.properties file used
  by mod_jk. If not set, defaults to
  "conf/jk/workers.properties". 

modjserv - path to Apache JServ plugin module file.
  If not set, defaults to
  "modules/ApacheModuleJServ.dll" on windows, 
  "modules/Jserv.nlm" on netware, and
  "libexec/mod_jserv.so" everywhere else. 
  
modjk - path to Apache mod_jk plugin file. If not
   set, defaults to "modules/mod_jk.dll" on windows,
   "modules/mod_jk.nlm" on netware, and
   "libexec/mod_jk.so" everywhere else. 

jklog - path to log file to be used by mod_jk. 

All of these attributes are optional.

Please try the patch out and let me know if you have
any problems.

Send me a +1 if you think it should be committed.

Cheers,

Mel


__________________________________________________
Do You Yahoo!?
Get email at your own domain with Yahoo! Mail. 
http://personal.mail.yahoo.com/