You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2023/06/20 15:21:58 UTC
[doris] branch master updated: [fix](profile) delete useless profile add_child #20989
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6d579d924d [fix](profile) delete useless profile add_child #20989
6d579d924d is described below
commit 6d579d924d580729bd7c76d76608cf2c549981c4
Author: Xinyi Zou <zo...@gmail.com>
AuthorDate: Tue Jun 20 23:21:52 2023 +0800
[fix](profile) delete useless profile add_child #20989
---
be/src/olap/delta_writer.cpp | 1 -
be/src/runtime/load_channel.cpp | 1 -
be/src/runtime/tablets_channel.cpp | 2 --
be/src/vec/common/sort/sorter.h | 2 --
be/src/vec/exec/join/vjoin_node_base.cpp | 1 -
5 files changed, 7 deletions(-)
diff --git a/be/src/olap/delta_writer.cpp b/be/src/olap/delta_writer.cpp
index 5c0d7dc2d2..16fc02dbc0 100644
--- a/be/src/olap/delta_writer.cpp
+++ b/be/src/olap/delta_writer.cpp
@@ -88,7 +88,6 @@ DeltaWriter::DeltaWriter(WriteRequest* req, StorageEngine* storage_engine, Runti
void DeltaWriter::_init_profile(RuntimeProfile* profile) {
_profile = profile->create_child(fmt::format("DeltaWriter {}", _req.tablet_id), true, true);
- profile->add_child(_profile, false, nullptr);
_lock_timer = ADD_TIMER(_profile, "LockTime");
_sort_timer = ADD_TIMER(_profile, "MemTableSortTime");
_agg_timer = ADD_TIMER(_profile, "MemTableAggTime");
diff --git a/be/src/runtime/load_channel.cpp b/be/src/runtime/load_channel.cpp
index 925ef17308..5067e2f19a 100644
--- a/be/src/runtime/load_channel.cpp
+++ b/be/src/runtime/load_channel.cpp
@@ -56,7 +56,6 @@ void LoadChannel::_init_profile() {
_profile->create_child(fmt::format("LoadChannel load_id={} (host={}, backend_id={})",
_load_id.to_string(), _sender_ip, _backend_id),
true, true);
- _profile->add_child(_self_profile, false, nullptr);
_add_batch_number_counter = ADD_COUNTER(_self_profile, "NumberBatchAdded", TUnit::UNIT);
_peak_memory_usage_counter = ADD_COUNTER(_self_profile, "PeakMemoryUsage", TUnit::BYTES);
_add_batch_timer = ADD_TIMER(_self_profile, "AddBatchTime");
diff --git a/be/src/runtime/tablets_channel.cpp b/be/src/runtime/tablets_channel.cpp
index fe0465a780..21cee45097 100644
--- a/be/src/runtime/tablets_channel.cpp
+++ b/be/src/runtime/tablets_channel.cpp
@@ -73,11 +73,9 @@ TabletsChannel::~TabletsChannel() {
void TabletsChannel::_init_profile(RuntimeProfile* profile) {
_profile =
profile->create_child(fmt::format("TabletsChannel {}", _key.to_string()), true, true);
- profile->add_child(_profile, false, nullptr);
_add_batch_number_counter = ADD_COUNTER(_profile, "NumberBatchAdded", TUnit::UNIT);
auto* memory_usage = _profile->create_child("PeakMemoryUsage", true, true);
- _profile->add_child(memory_usage, false, nullptr);
_slave_replica_timer = ADD_TIMER(_profile, "SlaveReplicaTime");
_memory_usage_counter = memory_usage->AddHighWaterMarkCounter("Total", TUnit::BYTES);
_write_memory_usage_counter = memory_usage->AddHighWaterMarkCounter("Write", TUnit::BYTES);
diff --git a/be/src/vec/common/sort/sorter.h b/be/src/vec/common/sort/sorter.h
index f5a12db3c0..383b6ff75e 100644
--- a/be/src/vec/common/sort/sorter.h
+++ b/be/src/vec/common/sort/sorter.h
@@ -62,8 +62,6 @@ public:
external_sort_bytes_threshold_ = state->external_sort_bytes_threshold();
if (profile != nullptr) {
block_spill_profile_ = profile->create_child("BlockSpill", true, true);
- profile->add_child(block_spill_profile_, false, nullptr);
-
spilled_block_count_ = ADD_COUNTER(block_spill_profile_, "BlockCount", TUnit::UNIT);
spilled_original_block_size_ =
ADD_COUNTER(block_spill_profile_, "BlockBytes", TUnit::BYTES);
diff --git a/be/src/vec/exec/join/vjoin_node_base.cpp b/be/src/vec/exec/join/vjoin_node_base.cpp
index 3be9284906..57870a0ac8 100644
--- a/be/src/vec/exec/join/vjoin_node_base.cpp
+++ b/be/src/vec/exec/join/vjoin_node_base.cpp
@@ -108,7 +108,6 @@ VJoinNodeBase::VJoinNodeBase(ObjectPool* pool, const TPlanNode& tnode, const Des
Status VJoinNodeBase::prepare(RuntimeState* state) {
RETURN_IF_ERROR(ExecNode::prepare(state));
_build_phase_profile = runtime_profile()->create_child("BuildPhase", true, true);
- runtime_profile()->add_child(_build_phase_profile, false, nullptr);
_build_get_next_timer = ADD_TIMER(_build_phase_profile, "BuildGetNextTime");
_build_timer = ADD_TIMER(_build_phase_profile, "BuildTime");
_build_rows_counter = ADD_COUNTER(_build_phase_profile, "BuildRows", TUnit::UNIT);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org