[jira] [Commented] (NIFI-5208) Editing a flow on a Disconnected Node

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490743#comment-16490743 ] 

ASF GitHub Bot commented on NIFI-5208:
--------------------------------------

GitHub user mcgilman opened a pull request:

    https://github.com/apache/nifi/pull/2740

    NIFI-5208: Restore dialog when nodes disconnects

    NIFI-5208:
    - Fixing missing message when a node is disconnected from a cluster.
    - Updating endpoints to accept a flag to allow for changes to be made to a disconnected node.
    - Updating custom UIs to acknowledge disconnected nodes prior to performing modifications.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcgilman/nifi NIFI-5208

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2740.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2740
    
----
commit ab6d7aaf8f81ef2136c6f94c1e5b4e121188c4cb
Author: Matt Gilman <ma...@...>
Date:   2018-05-22T14:32:56Z

    NIFI-5208:
    - Fixing missing message when a node is disconnected from a cluster.
    - Updating endpoints to accept a flag to allow for changes to be made to a disconnected node.
    - Updating custom UIs to acknowledge disconnected nodes prior to performing modifications.

----


> Editing a flow on a Disconnected Node
> -------------------------------------
>
>                 Key: NIFI-5208
>                 URL: https://issues.apache.org/jira/browse/NIFI-5208
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Core UI
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Critical
>
> Currently, editing on a flow on a disconnected node is allowed. This feature is useful when needing to debug a node-specific environmental issue prior to re-joining the cluster. However, this can also lead to issues when the user doesn't realize that the node they are viewing is disconnected. This was never an issue in our 0.x baseline as viewing the disconnected node required the user to manually direct their browser away from the NCM and towards the disconnected node.
> In 1.x, this can happen transparently without the need for the user to redirect their browser. There is a label at the top to indicate that the node is disconnected but this is not sufficient. If the user continues with their edits, it will make it difficult to re-join the cluster without manual inventions to retain their changes.
> There is a dialog that should inform the user that the cluster connection state has changed. However, there appears to be a regression that is preventing that dialog from showing. We should restore this dialog and make it confirm the users intent to make changes in a disconnected state. Furthermore, changes should be prevented without this confirmation. Confirmation should happen anytime the cluster connected state changes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)