You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2007/04/06 14:26:17 UTC
svn commit: r526133 - /tomcat/tc6.0.x/trunk/build.xml
Author: remm
Date: Fri Apr 6 05:26:16 2007
New Revision: 526133
URL: http://svn.apache.org/viewvc?view=rev&rev=526133
Log:
- Fix variable.
Modified:
tomcat/tc6.0.x/trunk/build.xml
Modified: tomcat/tc6.0.x/trunk/build.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?view=diff&rev=526133&r1=526132&r2=526133
==============================================================================
--- tomcat/tc6.0.x/trunk/build.xml (original)
+++ tomcat/tc6.0.x/trunk/build.xml Fri Apr 6 05:26:16 2007
@@ -517,7 +517,7 @@
</target>
<!-- Download and dependency building -->
- <target name="setproxy" if="useproxy">
+ <target name="setproxy" if="proxy.use">
<taskdef name="setproxy"
classname="org.apache.tools.ant.taskdefs.optional.net.SetProxy" />
<setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r526133 - /tomcat/tc6.0.x/trunk/build.xml
Posted by Takayuki Kaneko <ka...@gmail.com>.
Thanks.
In passing, please fix extras.xml, too.
- Takayuki
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r526133 - /tomcat/tc6.0.x/trunk/build.xml
Posted by Remy Maucherat <re...@apache.org>.
Peter Rossbach wrote:
> HI Remy,
>
> but this means that proxy.use=off also true and proxy is set.
>
> I think we can better use the following code:
>
> <target name="proxyflags">
> <!-- check proxy parameters. -->
> <condition property="useproxy">
> <equals arg1="${proxy.use}" arg2="on" />
> </condition>
> </target>
>
> <target name="setproxy" depends="proxyflags" if="useproxy">
>
> At tomcat 5.5 the proxyflags dependencies also missing.
Ok.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r526133 - /tomcat/tc6.0.x/trunk/build.xml
Posted by Peter Rossbach <pr...@objektpark.de>.
HI Remy,
but this means that proxy.use=off also true and proxy is set.
I think we can better use the following code:
<target name="proxyflags">
<!-- check proxy parameters. -->
<condition property="useproxy">
<equals arg1="${proxy.use}" arg2="on" />
</condition>
</target>
<target name="setproxy" depends="proxyflags" if="useproxy">
At tomcat 5.5 the proxyflags dependencies also missing.
Regards
Peter
Am 06.04.2007 um 14:26 schrieb remm@apache.org:
> Author: remm
> Date: Fri Apr 6 05:26:16 2007
> New Revision: 526133
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=526133
> Log:
> - Fix variable.
>
> Modified:
> tomcat/tc6.0.x/trunk/build.xml
>
> Modified: tomcat/tc6.0.x/trunk/build.xml
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?
> view=diff&rev=526133&r1=526132&r2=526133
> ======================================================================
> ========
> --- tomcat/tc6.0.x/trunk/build.xml (original)
> +++ tomcat/tc6.0.x/trunk/build.xml Fri Apr 6 05:26:16 2007
> @@ -517,7 +517,7 @@
> </target>
>
> <!-- Download and dependency building -->
> - <target name="setproxy" if="useproxy">
> + <target name="setproxy" if="proxy.use">
> <taskdef name="setproxy"
>
> classname="org.apache.tools.ant.taskdefs.optional.net.SetProxy" />
> <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>