You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "zaminalishah (via GitHub)" <gi...@apache.org> on 2025/07/21 18:30:17 UTC

[PR] fix(drill-to-detail): drill to detail by axis with label on axis column [superset]

zaminalishah opened a new pull request, #34257:
URL: https://github.com/apache/superset/pull/34257

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   When the axis column in a timeseries chart had a label set on the dataset level then the drill to detail by axis value wasnt working. The problem was that we were sending the label to the backend for filtering but the backend expected the column name.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   https://github.com/user-attachments/assets/2a15da9c-702d-4e83-8b7c-941ebcf3fffd
   
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #33907 
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(drill-to-detail): drill to detail by axis with label on axis column [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.

rusackas commented on PR #34257:
URL: https://github.com/apache/superset/pull/34257#issuecomment-3097971428

   Thanks for the PR! Approving CI to run 🤞 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(drill-to-detail): drill to detail by axis with label on axis column [superset]

Posted by "msyavuz (via GitHub)" <gi...@apache.org>.

msyavuz closed pull request #34257: fix(drill-to-detail): drill to detail by axis with label on axis column
URL: https://github.com/apache/superset/pull/34257


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(drill-to-detail): drill to detail by axis with label on axis column [superset]

Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.

korbit-ai[bot] commented on code in PR #34257:
URL: https://github.com/apache/superset/pull/34257#discussion_r2219961157


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx:
##########
@@ -190,7 +190,7 @@ export default function EchartsTimeseries({
               // if the xAxis is '__timestamp', granularity_sqla will be the column of filter
               xAxis.label === DTTM_ALIAS
                 ? formData.granularitySqla
-                : xAxis.label,
+                : formData.xAxis,

Review Comment:
   ### Missing explanation for timestamp column handling <sub>![category Documentation](https://img.shields.io/badge/Documentation-7c3aed)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The logic for selecting between granularitySqla and xAxis based on DTTM_ALIAS lacks documentation explaining why this branching is necessary.
   
   
   ###### Why this matters
   Future developers may not understand the significance of this condition, potentially leading to bugs when modifying time-related filtering logic.
   
   ###### Suggested change ∙ *Feature Preview*
   // For timestamp filters, we need to use granularitySqla when the x-axis is a timestamp
   // column (DTTM_ALIAS), otherwise use the configured x-axis column
   xAxis.label === DTTM_ALIAS
   ? formData.granularitySqla
   : formData.xAxis,
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91fdafd9-c506-4ff3-a8ac-ec269f581641/upvote) [![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91fdafd9-c506-4ff3-a8ac-ec269f581641?what_not_true=true)  [![Not in Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91fdafd9-c506-4ff3-a8ac-ec269f581641?what_out_of_scope=true) [![Not in coding standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91fdafd9-c506-4ff3-a8ac-ec269f581641?what_not_in_standard=true) [![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/91fdafd9-c506-4ff3-a8ac-ec269f581641)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:2a59a39f-5cf4-4c50-96eb-7dbaf0da00e4 -->
   
   
   [](2a59a39f-5cf4-4c50-96eb-7dbaf0da00e4)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org