You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wcy666103 (via GitHub)" <gi...@apache.org> on 2024/11/28 03:26:35 UTC

[PR] Close-NodeCache-before-Curator [dubbo]

wcy666103 opened a new pull request, #14950:
URL: https://github.com/apache/dubbo/pull/14950

   ## What is the purpose of the change?
   
   https://github.com/apache/dubbo/issues/10150#issuecomment-2505167696
   
   Close every NodeCache before close CuratorFramework.
   
   ## Checklist
   - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [x] Make sure gitHub actions can pass. [Why the workflow is failing and how to fix it?](../CONTRIBUTING.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Close-NodeCache-before-Curator [dubbo]

Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 closed pull request #14950: Close-NodeCache-before-Curator
URL: https://github.com/apache/dubbo/pull/14950


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Close-NodeCache-before-Curator [dubbo]

Posted by "wcy666103 (via GitHub)" <gi...@apache.org>.
wcy666103 commented on PR #14950:
URL: https://github.com/apache/dubbo/pull/14950#issuecomment-2505320888

   The `nodeCacheMap` is a cache, and each cache should not be closed when the current client is destroyed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Close-NodeCache-before-Curator [dubbo]

Posted by "imfms (via GitHub)" <gi...@apache.org>.
imfms commented on PR #14950:
URL: https://github.com/apache/dubbo/pull/14950#issuecomment-2505536537

   > The `nodeCacheMap` is a cache, and each cache should not be closed when the current client is destroyed.
   ```java
   private static Map<String, NodeCache> nodeCacheMap = new ConcurrentHashMap<>();
   ```
   Global cache across multiple Dubbo instances in the same process?
   It seems that Nodecache (CuratorFramework client, String path) holds a reference to the CuratorFramework-client, I don't know if there is a problem with different client-cache across multiple instances.
   
   I'm not very familiar with the Dubbo code, or maybe I'm just overthinking it.
   I've temporarily ignored NodeCache's ERROR log: Expected state [ STARTED ] was [ STOPPED]
   
   Thanks for your work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org