You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/28 16:22:53 UTC

[GitHub] [bookkeeper] dlg99 commented on pull request #3352: Basic function: directories to store index files

dlg99 commented on PR #3352:
URL: https://github.com/apache/bookkeeper/pull/3352#issuecomment-1168934897

   @StevenLuMT Can you please follow up with a PR to use junit4 in the test, to make sure tests aren't skipped and work as expected?
   
   junit5 is imported in pom
   ```
       <junit.version>4.12</junit.version>
       <!-- required by zookeeper test utilities imported from ZooKeeper -->
       <junit5.version>5.8.2</junit5.version>
    ```
   but it is not used in the tests
   ```
   $ ggrep -rI "import org.junit.jupiter" 
   $
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org