You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "cardamon (via GitHub)" <gi...@apache.org> on 2023/08/09 08:16:23 UTC
[GitHub] [activemq-artemis] cardamon opened a new pull request, #4576: Fix a memory leak in HandlerBase.
cardamon opened a new pull request, #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576
The `ThreadLocal`'s value in `HandlerBase` is never cleaned up.
Found by log statements issued by Tomcat during the undeployment of a web application that uses an embedded broker instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4576: Fix a memory leak in HandlerBase.
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1703176250
@cardamon, do you plan on following up on this PR with the requested changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] cardamon commented on pull request #4576: Fix a memory leak in HandlerBase.
Posted by "cardamon (via GitHub)" <gi...@apache.org>.
cardamon commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1673090016
Thanks, will do!
(may be a few days before I get to it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix a memory leak in HandlerBase. [activemq-artemis]
Posted by "cardamon (via GitHub)" <gi...@apache.org>.
cardamon commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1753035195
> @cardamon : a check-leak test?
>
> https://github.com/apache/activemq-artemis/tree/main/tests/leak-tests
Didn't knew that existed as I'm not that familiar with the project but I'll have a look at that, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix a memory leak in HandlerBase. [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1749535334
a check-leak test?
https://github.com/apache/activemq-artemis/tree/main/tests/leak-tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] cardamon commented on pull request #4576: Fix a memory leak in HandlerBase.
Posted by "cardamon (via GitHub)" <gi...@apache.org>.
cardamon commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1703462232
Actually, I'm not sure how this could be easily & meaningfully tested in a unit test. `ThreadLocal` instances are really quite annoying. The don't allow their value to be queried without actually setting it.
One direction would be for the `ThreadLocal` to be mocked with Mockito, and then verify that the correct calls are made. But the unit test would just be a replication of the logic of the code that's being tested. Although it would I suppose prevent regressions by accidental modification of code.
Would that be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4576: Fix a memory leak in HandlerBase.
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-1671595848
This looks good. Thanks for the contribution!
However, before merging this needs a couple of things...
First, it needs an associated Jira. If you don't already have an Apache Jira account you can [request one](https://selfserve.apache.org/jira-account.html). I'll watch for your request and approve it ASAP. Once you create a Jira you should update the commit message to reference it. See more details about commit messages in our [Hacking Guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/_code.adoc#commitMessageDetails).
Second, it needs a test to both validate the fix and also prevent regressions in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix a memory leak in HandlerBase. [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic closed pull request #4576: Fix a memory leak in HandlerBase.
URL: https://github.com/apache/activemq-artemis/pull/4576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix a memory leak in HandlerBase. [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4576:
URL: https://github.com/apache/activemq-artemis/pull/4576#issuecomment-2050015886
This is being replaced by https://github.com/apache/activemq-artemis/pull/4880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org