You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2018/04/18 17:36:33 UTC

svn commit: r1829465 - in /commons/proper/validator/trunk/src: changes/changes.xml main/java/org/apache/commons/validator/routines/IBANValidator.java test/java/org/apache/commons/validator/routines/IBANValidatorTest.java

Author: sebb
Date: Wed Apr 18 17:36:32 2018
New Revision: 1829465

URL: http://svn.apache.org/viewvc?rev=1829465&view=rev
Log:
IBANValidator fails for El Salvador

Modified:
    commons/proper/validator/trunk/src/changes/changes.xml
    commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
    commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java

Modified: commons/proper/validator/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/changes/changes.xml?rev=1829465&r1=1829464&r2=1829465&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/changes/changes.xml (original)
+++ commons/proper/validator/trunk/src/changes/changes.xml Wed Apr 18 17:36:32 2018
@@ -98,6 +98,10 @@ Apache Commons Validator.
 For the current list of dependencies, please see
 http://commons.apache.org/validator/dependencies.html
   ">
+    <action issue="VALIDATOR-438" type="fix" dev="sebb">
+    IBANValidator fails for El Salvador
+    Add definition
+    </action>
     <action type="update" dev="sebb">
     IANA TLD lists: Updated to Version 2018031400, Last Updated Wed Mar 14 07:07:01 2018 UTC
     </action>

Modified: commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java?rev=1829465&r1=1829464&r2=1829465&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java (original)
+++ commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/IBANValidator.java Wed Apr 18 17:36:32 2018
@@ -162,6 +162,7 @@ public class IBANValidator {
             new Validator("SK", 24, "SK\\d{22}"                             ), // Slovak Republic
             new Validator("SM", 27, "SM\\d{2}[A-Z]{1}\\d{10}[A-Z0-9]{12}"   ), // San Marino
             new Validator("ST", 25, "ST\\d{23}"                             ), // Sao Tome and Principe
+            new Validator("SV", 28, "SV\\d{2}[A-Z]{4}\\d{20}"             ) , // El Salvador
             new Validator("TL", 23, "TL\\d{21}"                             ), // Timor-Leste
             new Validator("TN", 24, "TN\\d{22}"                             ), // Tunisia
             new Validator("TR", 26, "TR\\d{8}[A-Z0-9]{16}"                  ), // Turkey

Modified: commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java?rev=1829465&r1=1829464&r2=1829465&view=diff
==============================================================================
--- commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java (original)
+++ commons/proper/validator/trunk/src/test/java/org/apache/commons/validator/routines/IBANValidatorTest.java Wed Apr 18 17:36:32 2018
@@ -109,6 +109,8 @@ public class IBANValidatorTest {
             "SK3112000000198742637541",
             "SM86U0322509800000000270100",
             "ST68000100010051845310112",
+            "SV62CENR00000000000000700025",
+            "SV43ACAT00000000000000123123",
             "TL380080012345678910157",
             "TN5910006035183598478831",
             "TR330006100519786457841326",