You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/12/28 16:34:19 UTC

[GitHub] [incubator-tvm] tqchen commented on issue #4594: [relay][refactor] Refactor Op::Get calls to IsOp utility

tqchen commented on issue #4594: [relay][refactor] Refactor Op::Get calls to IsOp utility
URL: https://github.com/apache/incubator-tvm/pull/4594#issuecomment-569430897
 
 
   Note, if we are concerned about efficiency, I still think we should separate Op::Get from checking. Note that we can always cache an op by storing it in a static var, or a class once and use that op to do equivalence checking. 
   
   Perhaps we should document this pattern and move away from getting op everytime

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services