You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/11/24 18:12:38 UTC
[GitHub] [accumulo-testing] Manno15 opened a new pull request #172: Fix build warnings in a few classes due to deprication
Manno15 opened a new pull request #172:
URL: https://github.com/apache/accumulo-testing/pull/172
There were a few build warnings due to Class.newInstance() being deprecated. I am not 100% sure if this is the most ideal fix but it does remove those warnings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo edited a comment on pull request #172: Fix build warnings in a few classes due to deprication
Posted by GitBox <gi...@apache.org>.
DomGarguilo edited a comment on pull request #172:
URL: https://github.com/apache/accumulo-testing/pull/172#issuecomment-978216209
> I am not 100% sure if this is the most ideal fix but it does remove those warnings.
I think this is fine. This is what we did in #151 for the same issue but just for one occurrence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] milleruntime commented on a change in pull request #172: Fix build warnings in a few classes due to deprication
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #172:
URL: https://github.com/apache/accumulo-testing/pull/172#discussion_r756411738
##########
File path: src/main/java/org/apache/accumulo/testing/performance/impl/PerfTestRunner.java
##########
@@ -41,7 +41,7 @@ public static void main(String[] args) throws Exception {
String accumuloVersion = args[2];
String outputDir = args[3];
- PerformanceTest perfTest = Class.forName(className).asSubclass(PerformanceTest.class)
+ PerformanceTest perfTest = Class.forName(className).asSubclass(PerformanceTest.class).getDeclaredConstructor()
Review comment:
Format
```suggestion
PerformanceTest perfTest = Class.forName(className).asSubclass(PerformanceTest.class)
.getDeclaredConstructor().newInstance();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] DomGarguilo commented on pull request #172: Fix build warnings in a few classes due to deprication
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on pull request #172:
URL: https://github.com/apache/accumulo-testing/pull/172#issuecomment-978216209
> I am not 100% sure if this is the most ideal fix but it does remove those warnings.
I think this is fine. This is what we did in #151 for the same issue but just for occurrence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-testing] Manno15 merged pull request #172: Fix build warnings in a few classes due to deprication
Posted by GitBox <gi...@apache.org>.
Manno15 merged pull request #172:
URL: https://github.com/apache/accumulo-testing/pull/172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org