You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Jason Kary <jk...@cisco.com> on 2001/09/21 22:52:11 UTC

[PATCH] BugFix -> IntakeTool Turbine 3

Hi,

Here is a patch file for the file org.apache.turbine.tool.IntakeTool.
When initializing the intake tool I was getting a method not found
error.  It seemed to be a casting problem...

Take Care.
Jason Kary


Re: [PATCH] BugFix -> IntakeTool Turbine 3

Posted by Daniel Rall <dl...@finemaltcoding.com>.
It is not necessary, as super.init() takes an Object (also, because
ParameterParser extends ValueParser, ParameterParser is a
ValueParser).

John McNally <jm...@collab.net> writes:

> I do not see what this accomplishes (how it fixes an error).  You are
> explicitely casting a ParameterParser to a ValueParser, but this should
> not be required.
> 
> Jason Kary wrote:
> > 
> > Index: src/tool/org/apache/turbine/tool/IntakeTool.java
> > ===================================================================
> > RCS file: /home/cvspublic/jakarta-turbine-3/src/tool/org/apache/turbine/tool/IntakeTool.java,v
> > retrieving revision 1.3
> > diff -r1.3 IntakeTool.java
> > 57a58
> > > import org.apache.fulcrum.util.parser.ValueParser;
> > 58a60
> > > import org.apache.turbine.ParameterParser;
> > 80c82,84
> > <         super.init( ((RunData)runData).getParameters() );
> > ---
> > >               RunData rd = (RunData)runData;
> > >               ParameterParser pp = rd.getParameters();
> > >         super.init( (ValueParser)pp );
> > 

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: [PATCH] BugFix -> IntakeTool Turbine 3

Posted by John McNally <jm...@collab.net>.
I do not see what this accomplishes (how it fixes an error).  You are
explicitely casting a ParameterParser to a ValueParser, but this should
not be required.

john mcnally

Jason Kary wrote:
> 
> Hi,
> 
> Here is a patch file for the file org.apache.turbine.tool.IntakeTool.
> When initializing the intake tool I was getting a method not found
> error.  It seemed to be a casting problem...
> 
> Take Care.
> Jason Kary
> 
>   ------------------------------------------------------------------------
> Index: src/tool/org/apache/turbine/tool/IntakeTool.java
> ===================================================================
> RCS file: /home/cvspublic/jakarta-turbine-3/src/tool/org/apache/turbine/tool/IntakeTool.java,v
> retrieving revision 1.3
> diff -r1.3 IntakeTool.java
> 57a58
> > import org.apache.fulcrum.util.parser.ValueParser;
> 58a60
> > import org.apache.turbine.ParameterParser;
> 80c82,84
> <         super.init( ((RunData)runData).getParameters() );
> ---
> >               RunData rd = (RunData)runData;
> >               ParameterParser pp = rd.getParameters();
> >         super.init( (ValueParser)pp );
> 
>   ------------------------------------------------------------------------
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: turbine-dev-help@jakarta.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org


Re: [PATCH] BugFix -> IntakeTool Turbine 3

Posted by Jon Stevens <jo...@latchkey.com>.
on 9/21/01 1:52 PM, "Jason Kary" <jk...@cisco.com> wrote:

> Hi,
> 
> Here is a patch file for the file org.apache.turbine.tool.IntakeTool.
> When initializing the intake tool I was getting a method not found
> error.  It seemed to be a casting problem...
> 
> Take Care.
> Jason Kary

Weird. It is working fine in Scarab...

-jon


---------------------------------------------------------------------
To unsubscribe, e-mail: turbine-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: turbine-dev-help@jakarta.apache.org