You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/22 22:29:46 UTC

[GitHub] [pulsar] phreed opened a new issue #5725: Relax PULSAR_HOME requirement.

phreed opened a new issue #5725: Relax PULSAR_HOME requirement.
URL: https://github.com/apache/pulsar/issues/5725
 
 
   **Is your feature request related to a problem? Please describe.**
   
   I am developing gradle plugins for nifi and pulsar. The main gradle task for the nifi-gradle-plugin is to produce nar files from gradle. The main task for the pulsar-gradle-plugin is to run sink-connectors, source-connectors, functions as localrun processes. This makes debugging of these components from withing IDE (idea) simpler. As I develop these tasks I am finding small things in pulsar that get in the way. 
   
   **Describe the solution you'd like**
   
   In https://github.com/apache/pulsar/blob/branch-2.4/pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java#L456
   There is a call to System.getenv("PULSAR_HOME") rather than  System.getProperty("PULSAR_HOME") . This makes it impossible to set PULSAR_HOME from within java, which is something I would like my plugin to be able to do.
   
   **Describe alternatives you've considered**
   
   Setting the PULSAR_HOME in my .bash_profile and logging out and back in.
   
   **Additional context**
   
   This may be better handled by having a custom LocalRunner.java for my gradle plugin.
   This may actually be the best approach.
   In that case I would like to see the LocalRunner be split in two. 
   1. The command line tool using JCommander
   2. Something like the following which is called by (1)
   [PulsarLocalRunner.kt.txt](https://github.com/apache/pulsar/files/3881675/PulsarLocalRunner.kt.txt)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services