You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/07/22 08:54:25 UTC

Review Request 23791: SENTRY-343 Privileges query from database support for "With Grant Option"

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23791/
-----------------------------------------------------------

Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Repository: sentry


Description
-------

Based on 'SENTRY-340 Database implement for "with grant option"' and 'SENTRY-341 Extend Thrift API for SentryStore to support "with grant option"'
The patch contains: 
1.Added grantOption to query filter. 
2.Minor change about query interface: changed the privilegeName to privilege entity.
3.The convertion between MSentryPrivilege and TSentryPrivilege.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 

Diff: https://reviews.apache.org/r/23791/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng


Re: Review Request 23791: SENTRY-343 Privileges query from database support for "With Grant Option"

Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23791/
-----------------------------------------------------------

(Updated July 31, 2014, 6:38 p.m.)


Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Repository: sentry


Description
-------

Based on 'SENTRY-340 Database implement for "with grant option"' and 'SENTRY-341 Extend Thrift API for SentryStore to support "with grant option"'
The patch contains: 
1.Added grantOption to query filter. 
2.Minor change about query interface: changed the privilegeName to privilege entity.
3.The convertion between MSentryPrivilege and TSentryPrivilege.


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 

Diff: https://reviews.apache.org/r/23791/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng


Re: Review Request 23791: SENTRY-343 Privileges query from database support for "With Grant Option"

Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23791/
-----------------------------------------------------------

(Updated July 28, 2014, 5:59 p.m.)


Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

Change code base on SENTRY-339.


Repository: sentry


Description
-------

Based on 'SENTRY-340 Database implement for "with grant option"' and 'SENTRY-341 Extend Thrift API for SentryStore to support "with grant option"'
The patch contains: 
1.Added grantOption to query filter. 
2.Minor change about query interface: changed the privilegeName to privilege entity.
3.The convertion between MSentryPrivilege and TSentryPrivilege.


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 

Diff: https://reviews.apache.org/r/23791/diff/


Testing
-------

Unit tests in local


Thanks,

Sun Dapeng